You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If there is a bad file type error, Comic Crawler goes into a 416 error loop:
Download file into foo.part.
Sniff file extension.
Bad file type error.
Retry, send range request.
HTTP 416.
Do we want to delete .part file?
The file is downloaded completely. The content is valid. The extension is also valid in this case. There's a bug in puremagic that reports the wrong extension.
Do we want to delete .part file on HTTP 416 error?
Probably no? The most common case of 416 is that a link is expired and we have to fetch the link again.
The main issue
There shouldn't be any .part file if the download is completed. Post processing should happen after renaming the file. So the process should be:
Download file into foo.part
Sniff file extension.
Rename to foo.docx
Bad file type error.
Delete the file (?).
Retry download.
But then it introduces a re-download loop.
Remove bad file type error?
It is used to detect URL redirection leading to an HTML page. It also provides an extension whitelist.
Maybe we can use a blacklist instead?
The text was updated successfully, but these errors were encountered:
If there is a bad file type error, Comic Crawler goes into a 416 error loop:
The file is downloaded completely. The content is valid. The extension is also valid in this case. There's a bug in puremagic that reports the wrong extension.
Probably no? The most common case of 416 is that a link is expired and we have to fetch the link again.
There shouldn't be any .part file if the download is completed. Post processing should happen after renaming the file. So the process should be:
But then it introduces a re-download loop.
It is used to detect URL redirection leading to an HTML page. It also provides an extension whitelist.
Maybe we can use a blacklist instead?
The text was updated successfully, but these errors were encountered: