Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ReconstructedParticle::PDG member? #34

Open
c-dilks opened this issue May 2, 2023 · 0 comments
Open

Remove ReconstructedParticle::PDG member? #34

c-dilks opened this issue May 2, 2023 · 0 comments

Comments

@c-dilks
Copy link
Member

c-dilks commented May 2, 2023

Is your feature request related to a problem? Please describe.

After some discussion in recent Software & Computing meetings, there may be some interest in removing the scalar member PDG from ReconstructedParticle, which in EICrecon is presently used for true PDG. Some points from these discussions:

  • MCRecoParticleAssociation::getSim::getPDG can be used to provide true PDG instead
    • not every out ReconstructedParticle object will be found in a MCRecoParticleAssociation, do those have a true PDG?
    • what should we do about members which may depend on PDG, such as ReconstructedParticle::mass? Or are these members filled without knowledge of the true PDG?
  • Removing member PDG brings us closer to EDM4hep model; it would be nice to switch to edm4hep::ReconstructedParticle, however, relations such as vertex, track, and cluster are to the EDM4eic objects, so this does not seem practical at this time
  • Removing member PDG will break:
    • Juggler
    • Any EICrecon reconstruction algorithms which use it
    • User analysis code
  • ReconstructedParticle::getParticleIDUsed and ReconstructedParticle::getParticleIDs will be used for PID objects, which in turn contain the PDG value(s) from PID

Let's use this Github issue to continue the discussion and eventually converge on a path forward for the future.
@sly2j @Chao1009 @wdconinc @mdiefent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant