Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish hcert-kotlin on npm #49

Open
delixfe opened this issue Jul 7, 2021 · 2 comments
Open

Publish hcert-kotlin on npm #49

delixfe opened this issue Jul 7, 2021 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed prio:low target:js

Comments

@delixfe
Copy link

delixfe commented Jul 7, 2021

Could you publish the JS library on npmjs.com or as GH package?
This would help a lot :).

CC: @mofobo-bit

@JesusMcCloud
Copy link
Contributor

This is a tricky subject. We required some workarounds to package it even as a UMD module, which is partially rooted in upstream bugs. See:

alias[moduleName + '-jsLegacy'] = moduleName + '-js-legacy'

We'd very much appreciate help on this. The "ground truth" for the webpack'd UMD distribution is actually a valid node module. So if you successfully manage to add build/packages/js/hcert as a dependency to your node project, let us know how you pulled it off, and we'll see what we can do.
However, we targeted the browser and node was never a requirement, so we directly depend on quite some browserified libraries, which will almost certainly cause issues. "Fixing" this would require changes to the build process. There's probably a way to accomplish this, but this is a non-priority for us, so we are very hesitant to invest in this.
You can, of course, directly integrate the UMD module we currently provide with your node app (with all obvious drawbacks of this approach).

@delixfe
Copy link
Author

delixfe commented Jul 9, 2021

@JesusMcCloud Thanks for your explanation. We use JavaScript mainly for our API tests and hoped for a simple solution :).
We do not have resources to follow up right now, but I leave the issue open. Maybe someone else steps in.

@JesusMcCloud JesusMcCloud added prio:low target:js enhancement New feature or request help wanted Extra attention is needed labels Jul 23, 2021
JesusMcCloud added a commit that referenced this issue Oct 7, 2021
Since https://youtrack.jetbrains.com/issue/KT-43237
is fixed (also for all our dependencies), we can drop the
workaround.

This also means that we could probably add a second JS target
without all the browserified node dependencies and directly
publish to npmjs.com in the future.
Hence, this paves the way to addressing #49.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed prio:low target:js
Projects
None yet
Development

No branches or pull requests

2 participants