Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests in the 04-phonebook refer to the functions that are neither defined by default nor asked to be implemented #7

Open
Sampo-K opened this issue Oct 22, 2021 · 0 comments

Comments

@Sampo-K
Copy link

Sampo-K commented Oct 22, 2021

Tests refer to the phonebook._to_string() and phonebook._read() that are not included in the specification of the phonebook.py file. I implemented these myself by checking what the test code does but should the assignment be done in this way? I think this is not clearly stated in the assignment documentation.

Another slightly confusing thing in the assignment documentation was that the regexp part talks about regexp that requires the phone number to start with "+" but the actual assignment accepts both numbers with and without "+" as it uses a bit different regexp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant