Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Positional Encoding #38

Open
schonIs opened this issue Sep 17, 2024 · 2 comments
Open

Positional Encoding #38

schonIs opened this issue Sep 17, 2024 · 2 comments

Comments

@schonIs
Copy link

schonIs commented Sep 17, 2024

I am currently conducting research on applying Transformer models to EEG signals. In your paper, I learned that by combining CNN and Transformer, it is possible to learn both global and local features. However, my question is why positional encoding is not added to the data input into the Transformer after the convolution with CNN. Could you please explain the reason for this?

@eeyhsong
Copy link
Owner

Hello @schonIs,

Happy to see you find this interesting part. I've also tried some position encoding techniques, but there was no significant improvement. I think that's due to the convolution layers performing a role for capturing position information.

Best regards,
Song

@schonIs
Copy link
Author

schonIs commented Oct 17, 2024

Thank you for your quick reply and opinion about my question.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants