Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concatenated SMS handling has a nasty race condition that drops messages on the floor (!) #16

Open
eeeeeta opened this issue Jun 16, 2018 · 0 comments

Comments

@eeeeeta
Copy link
Owner

eeeeeta commented Jun 16, 2018

If we process multiple CSMS parts in parallel, two attempts to set the room state can race with each other, meaning that we clobber one of the CSMS parts with the other :(

To be honest, the messages aren't dropped on the floor, because this is Matrix; we should be able to get at them with some room state poking. Still, not fun.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant