From d82c30b73521557aec242c530e88d6e92d01752a Mon Sep 17 00:00:00 2001 From: "omer.habib" Date: Sat, 21 Sep 2024 00:06:02 +0500 Subject: [PATCH 1/2] fix: Update bottom nav icons for selected/unselected state - Update the bottom nav icons on Main Dashboard for selected/unselected state fix: LEARNER-10137 --- app/src/main/res/drawable/app_ic_book.xml | 45 ------------------- .../res/drawable/app_ic_discover_selected.xml | 9 ++++ .../res/drawable/app_ic_discover_selector.xml | 5 +++ .../drawable/app_ic_discover_unselected.xml | 9 ++++ app/src/main/res/drawable/app_ic_home.xml | 38 ---------------- .../res/drawable/app_ic_learn_selected.xml | 9 ++++ .../res/drawable/app_ic_learn_selector.xml | 5 +++ .../res/drawable/app_ic_learn_unselected.xml | 9 ++++ app/src/main/res/drawable/app_ic_profile.xml | 31 ------------- .../res/drawable/app_ic_profile_selected.xml | 9 ++++ .../res/drawable/app_ic_profile_selector.xml | 5 +++ .../drawable/app_ic_profile_unselected.xml | 9 ++++ app/src/main/res/drawable/app_ic_rows.xml | 10 ----- app/src/main/res/menu/bottom_view_menu.xml | 6 +-- 14 files changed, 72 insertions(+), 127 deletions(-) delete mode 100644 app/src/main/res/drawable/app_ic_book.xml create mode 100644 app/src/main/res/drawable/app_ic_discover_selected.xml create mode 100644 app/src/main/res/drawable/app_ic_discover_selector.xml create mode 100644 app/src/main/res/drawable/app_ic_discover_unselected.xml delete mode 100644 app/src/main/res/drawable/app_ic_home.xml create mode 100644 app/src/main/res/drawable/app_ic_learn_selected.xml create mode 100644 app/src/main/res/drawable/app_ic_learn_selector.xml create mode 100644 app/src/main/res/drawable/app_ic_learn_unselected.xml delete mode 100644 app/src/main/res/drawable/app_ic_profile.xml create mode 100644 app/src/main/res/drawable/app_ic_profile_selected.xml create mode 100644 app/src/main/res/drawable/app_ic_profile_selector.xml create mode 100644 app/src/main/res/drawable/app_ic_profile_unselected.xml delete mode 100644 app/src/main/res/drawable/app_ic_rows.xml diff --git a/app/src/main/res/drawable/app_ic_book.xml b/app/src/main/res/drawable/app_ic_book.xml deleted file mode 100644 index 4245846af..000000000 --- a/app/src/main/res/drawable/app_ic_book.xml +++ /dev/null @@ -1,45 +0,0 @@ - - - - - - - - - - diff --git a/app/src/main/res/drawable/app_ic_discover_selected.xml b/app/src/main/res/drawable/app_ic_discover_selected.xml new file mode 100644 index 000000000..8f349a7a7 --- /dev/null +++ b/app/src/main/res/drawable/app_ic_discover_selected.xml @@ -0,0 +1,9 @@ + + + diff --git a/app/src/main/res/drawable/app_ic_discover_selector.xml b/app/src/main/res/drawable/app_ic_discover_selector.xml new file mode 100644 index 000000000..7a7245854 --- /dev/null +++ b/app/src/main/res/drawable/app_ic_discover_selector.xml @@ -0,0 +1,5 @@ + + + + + diff --git a/app/src/main/res/drawable/app_ic_discover_unselected.xml b/app/src/main/res/drawable/app_ic_discover_unselected.xml new file mode 100644 index 000000000..cd6cc1f0f --- /dev/null +++ b/app/src/main/res/drawable/app_ic_discover_unselected.xml @@ -0,0 +1,9 @@ + + + diff --git a/app/src/main/res/drawable/app_ic_home.xml b/app/src/main/res/drawable/app_ic_home.xml deleted file mode 100644 index b703f9f28..000000000 --- a/app/src/main/res/drawable/app_ic_home.xml +++ /dev/null @@ -1,38 +0,0 @@ - - - - - - - - - diff --git a/app/src/main/res/drawable/app_ic_learn_selected.xml b/app/src/main/res/drawable/app_ic_learn_selected.xml new file mode 100644 index 000000000..05a8c5ca9 --- /dev/null +++ b/app/src/main/res/drawable/app_ic_learn_selected.xml @@ -0,0 +1,9 @@ + + + diff --git a/app/src/main/res/drawable/app_ic_learn_selector.xml b/app/src/main/res/drawable/app_ic_learn_selector.xml new file mode 100644 index 000000000..af8e2a3c3 --- /dev/null +++ b/app/src/main/res/drawable/app_ic_learn_selector.xml @@ -0,0 +1,5 @@ + + + + + diff --git a/app/src/main/res/drawable/app_ic_learn_unselected.xml b/app/src/main/res/drawable/app_ic_learn_unselected.xml new file mode 100644 index 000000000..5362fca3e --- /dev/null +++ b/app/src/main/res/drawable/app_ic_learn_unselected.xml @@ -0,0 +1,9 @@ + + + diff --git a/app/src/main/res/drawable/app_ic_profile.xml b/app/src/main/res/drawable/app_ic_profile.xml deleted file mode 100644 index 1b241a689..000000000 --- a/app/src/main/res/drawable/app_ic_profile.xml +++ /dev/null @@ -1,31 +0,0 @@ - - - - - - - - diff --git a/app/src/main/res/drawable/app_ic_profile_selected.xml b/app/src/main/res/drawable/app_ic_profile_selected.xml new file mode 100644 index 000000000..8a530b071 --- /dev/null +++ b/app/src/main/res/drawable/app_ic_profile_selected.xml @@ -0,0 +1,9 @@ + + + diff --git a/app/src/main/res/drawable/app_ic_profile_selector.xml b/app/src/main/res/drawable/app_ic_profile_selector.xml new file mode 100644 index 000000000..198faf139 --- /dev/null +++ b/app/src/main/res/drawable/app_ic_profile_selector.xml @@ -0,0 +1,5 @@ + + + + + diff --git a/app/src/main/res/drawable/app_ic_profile_unselected.xml b/app/src/main/res/drawable/app_ic_profile_unselected.xml new file mode 100644 index 000000000..4ad191e8c --- /dev/null +++ b/app/src/main/res/drawable/app_ic_profile_unselected.xml @@ -0,0 +1,9 @@ + + + diff --git a/app/src/main/res/drawable/app_ic_rows.xml b/app/src/main/res/drawable/app_ic_rows.xml deleted file mode 100644 index eabe550d3..000000000 --- a/app/src/main/res/drawable/app_ic_rows.xml +++ /dev/null @@ -1,10 +0,0 @@ - - - diff --git a/app/src/main/res/menu/bottom_view_menu.xml b/app/src/main/res/menu/bottom_view_menu.xml index 0558f5c3b..c2f596561 100644 --- a/app/src/main/res/menu/bottom_view_menu.xml +++ b/app/src/main/res/menu/bottom_view_menu.xml @@ -4,19 +4,19 @@ From 8718b54f84a196f437b306848088cf50232e163c Mon Sep 17 00:00:00 2001 From: "omer.habib" Date: Thu, 26 Sep 2024 23:27:55 +0500 Subject: [PATCH 2/2] fix: Address PR comments - Update icon for discover tab --- app/src/main/res/drawable/app_ic_discover_selected.xml | 9 --------- app/src/main/res/drawable/app_ic_discover_selector.xml | 5 ----- ...c_discover_unselected.xml => app_ic_discover_tab.xml} | 0 app/src/main/res/menu/bottom_view_menu.xml | 2 +- 4 files changed, 1 insertion(+), 15 deletions(-) delete mode 100644 app/src/main/res/drawable/app_ic_discover_selected.xml delete mode 100644 app/src/main/res/drawable/app_ic_discover_selector.xml rename app/src/main/res/drawable/{app_ic_discover_unselected.xml => app_ic_discover_tab.xml} (100%) diff --git a/app/src/main/res/drawable/app_ic_discover_selected.xml b/app/src/main/res/drawable/app_ic_discover_selected.xml deleted file mode 100644 index 8f349a7a7..000000000 --- a/app/src/main/res/drawable/app_ic_discover_selected.xml +++ /dev/null @@ -1,9 +0,0 @@ - - - diff --git a/app/src/main/res/drawable/app_ic_discover_selector.xml b/app/src/main/res/drawable/app_ic_discover_selector.xml deleted file mode 100644 index 7a7245854..000000000 --- a/app/src/main/res/drawable/app_ic_discover_selector.xml +++ /dev/null @@ -1,5 +0,0 @@ - - - - - diff --git a/app/src/main/res/drawable/app_ic_discover_unselected.xml b/app/src/main/res/drawable/app_ic_discover_tab.xml similarity index 100% rename from app/src/main/res/drawable/app_ic_discover_unselected.xml rename to app/src/main/res/drawable/app_ic_discover_tab.xml diff --git a/app/src/main/res/menu/bottom_view_menu.xml b/app/src/main/res/menu/bottom_view_menu.xml index c2f596561..b9c852e9e 100644 --- a/app/src/main/res/menu/bottom_view_menu.xml +++ b/app/src/main/res/menu/bottom_view_menu.xml @@ -10,7 +10,7 @@