Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Implement video stream priority for native videos #62

Merged
merged 3 commits into from
Jan 16, 2025
Merged

chore: Implement video stream priority for native videos #62

merged 3 commits into from
Jan 16, 2025

Conversation

omerhabib26
Copy link

Description:

  • Handle video streaming priority based on user preference

fix: LEARNER-10260

@farhan-arshad-dev
Copy link
Member

As part of this PR, there is an update to the Room database structure (which might need update migration) that could potentially cause the app to crash. However, we have been unable to reproduce the issue due to downloaded videos not being accessible offline(Jira Ticket LEARNER-10282). Therefore, there are currently no plans to merge this PR until the issue of downloaded videos is resolved.

@omerhabib26 omerhabib26 force-pushed the 2U/omer/LEARNER-10260 branch from 0f39a4f to 200b02d Compare January 7, 2025 17:55
@HamzaIsrar12
Copy link

@omerhabib26 @farhan-arshad-dev

The Block Data is stored as a JSON string in the database, including the EncodedVideos object. Since this approach does not alter the database structure, no migration is needed.

Upon retrieval, the JSON parser assigns default values to primitives: 0 for int and long, and null for String. Additionally, changing the data type from int to long has no impact from the database’s perspective.

If the underlying functionality performs as expected, we’re good to merge the PR. 👍🏼

@omerhabib26 omerhabib26 merged commit 409542c into 2U/develop Jan 16, 2025
3 checks passed
@omerhabib26 omerhabib26 deleted the 2U/omer/LEARNER-10260 branch January 16, 2025 17:06
farhan-arshad-dev pushed a commit that referenced this pull request Jan 29, 2025
@omerhabib26 @farhan-arshad-dev
chore: Implement video stream priority for native videos (#62)
8148936 
chore: Implement video stream priority for native videos

- Handle video streaming priority based on user preference

fix: LEARNER-10260
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@farhan-arshad-dev farhan-arshad-dev farhan-arshad-dev approved these changes

@dixidroid dixidroid dixidroid approved these changes

@HamzaIsrar12 HamzaIsrar12 Awaiting requested review from HamzaIsrar12

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@omerhabib26 @farhan-arshad-dev @HamzaIsrar12 @dixidroid