fix: crash when internet disconnected right after opening a course #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dixidroid
force-pushed
the
fix/crash_no_internet_in_course
branch
from
19755ee to
19b4f16
Compare
dixidroid
requested review from
farhan-arshad-dev,
k1rill,
omerhabib26 and
HamzaIsrar12
There was a problem hiding this comment.
Hey @dixidroid, the underline issue is resolved. 👏🏻
I noticed a minor issue: we're loading the Video tab content from the cache, but not the Home tab content.
Steps to reproduce:
- Open a course and let it load.
- Return to the Main Dashboard.
- Open the course again and quickly switch to airplane mode.
- You’ll see that the Home Tab shows a "No Content" error, while the Videos Tab loads as expected.
Screenrecorder-2024-08-13-19-48-08-381.mp4
|
@HamzaIsrar12 Hi! |
HamzaIsrar12
approved these changes
Aug 15, 2024
|
Merging with a single approval since we need to include it in the release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The crash was fixed + added UI handlers for the Home and Videos tabs to stop infinite loading