feat: added ability to handle course errors #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dixidroid
force-pushed
the
feat/course_error_handling
branch
5 times, most recently
from
d85c202 to
6a3502d
Compare
dixidroid
force-pushed
the
feat/course_error_handling
branch
from
6a3502d to
9732384
Compare
omerhabib26
reviewed
Jul 25, 2024
| @@ -1,22 +1,33 @@ | |||
| package org.openedx.core.data.model | |||
|
|
|||
| import com.google.gson.annotations.SerializedName | |||
| import org.openedx.core.domain.model.CourseAccessDetails | |||
There was a problem hiding this comment.
As data model and domain model have the same names, so it will be a good approach if we can define the domain model alias.
i.e,
import org.openedx.core.domain.model.CourseAccessDetails as DomainCourseAccessDetails
| TimeUtils.iso8601ToDate(auditAccessExpires ?: ""), | ||
| coursewareAccess?.mapToDomain() | ||
| ) | ||
| fun mapToDomain() = CourseAccessDetails( |
There was a problem hiding this comment.
fun mapToDomain() = DomainCourseAccessDetails(
hasUnmetPrerequisites = hasUnmetPrerequisites,
isTooEarly = isTooEarly,
isStaff = isStaff,
auditAccessExpires = TimeUtils.iso8601ToDate(auditAccessExpires ?: ""),
coursewareAccess = coursewareAccess?.mapToDomain(),
)
|
|
||
| fun mapToRoomEntity(): CourseAccessDetailsDb = | ||
| CourseAccessDetailsDb(auditAccessExpires, coursewareAccess?.mapToRoomEntity()) | ||
| CourseAccessDetailsDb( | ||
| hasUnmetPrerequisites, isTooEarly, isStaff, |
There was a problem hiding this comment.
please mention the attributes names as well.
fun mapToRoomEntity(): CourseAccessDetailsDb =
CourseAccessDetailsDb(
hasUnmetPrerequisites = hasUnmetPrerequisites,
isTooEarly = isTooEarly,
isStaff = isStaff,
auditAccessExpires = auditAccessExpires,
coursewareAccess = coursewareAccess?.mapToRoomEntity()
)
| package org.openedx.core.data.model | ||
|
|
||
| import com.google.gson.annotations.SerializedName | ||
| import org.openedx.core.domain.model.CourseEnrollmentDetails |
| @SerializedName("course_info_overview") | ||
| val courseInfoOverview: CourseInfoOverview, | ||
| ) { | ||
| fun mapToDomain(): CourseEnrollmentDetails { |
| @@ -0,0 +1,9 @@ | |||
| <vector xmlns:android="http://schemas.android.com/apk/res/android" | |||
| @@ -0,0 +1,9 @@ | |||
| <vector xmlns:android="http://schemas.android.com/apk/res/android" | |||
| @@ -0,0 +1,9 @@ | |||
| <vector xmlns:android="http://schemas.android.com/apk/res/android" | |||
| @@ -0,0 +1,32 @@ | |||
| <vector xmlns:android="http://schemas.android.com/apk/res/android" | |||
There was a problem hiding this comment.
we need to update the file name, course_ic_arrow_up_circle.xml
also requires auto-format.
There was a problem hiding this comment.
better to rename it as course_ic_calendar.xml
|
Closing this PR in response of #18 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket