Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should as_variant adapts to std::variant? #263

Open
lichray opened this issue May 25, 2019 · 2 comments
Open

Should as_variant adapts to std::variant? #263

lichray opened this issue May 25, 2019 · 2 comments

Comments

@lichray
Copy link

lichray commented May 25, 2019

Currently it adapts to boost::variant, which looks either outdated or non-flexible.

@nilsdeppe
Copy link
Contributor

This would break C++11 incompatibility so I think making it adapt to std::variant to me seems like it would be less flexible. One option could be to have a macro flag that enables std::variant instead of boost::variant.

@jfalcou
Copy link
Collaborator

jfalcou commented Nov 19, 2019

we can also have brigand::as_std_variant next to it and have the file dependently included.
Also you can use wrap manually if you want to anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants