Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropping technical properties (Recommentation 20) #13

Open
kshychko opened this issue May 19, 2019 · 1 comment
Open

Dropping technical properties (Recommentation 20) #13

kshychko opened this issue May 19, 2019 · 1 comment
Labels
question Further information is requested rec20 related to Recommendation 20

Comments

@kshychko
Copy link
Contributor

There are some technical properties, which are likely will not be used and will be just ignored by API consumers.

The set of properties (and parameters) to be dropped shall be formed here and applied to the API definition.

So far we agreed to drop status property.

There is a proposal by @rgenoulaz to drop the following quantityCategories properties:

  • groupID
  • groupNumber

If we consider dropping them, I would add sector to the list.
Also in this case we should review unitsOfMeasure properties with the same approach.

@kshychko kshychko added the question Further information is requested label May 19, 2019
@cmsdroff
Copy link
Contributor

@kshychko looking through the documentation I think these are irrelevant for the future use in API, interestingly they are not mentioned in the explanatory notes.. so I think we are safe here, I also had some discussion with Sue Probert on this today so think we are ok. Pull request en-route post flight. Units of measure also modified.

cmsdroff added a commit that referenced this issue May 23, 2019
* Removed the discussed columns
* Added the pdf from UNECE website for future reference material
* modified swagger to reflect changez
kshychko pushed a commit that referenced this issue May 30, 2019
* Removed the discussed columns
* Added the pdf from UNECE website for future reference material
* modified swagger to reflect changez
kshychko added a commit that referenced this issue May 30, 2019
kshychko added a commit that referenced this issue May 30, 2019
@kshychko kshychko reopened this May 30, 2019
@kshychko kshychko added the rec20 related to Recommendation 20 label Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested rec20 related to Recommendation 20
Projects
None yet
Development

No branches or pull requests

2 participants