Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(metadata): Add query parameters for device parents/children. #5053

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat(metadata): Add query parameters for device parents/children. #5053

wants to merge 5 commits into from

Conversation

eaton-coreymutter
Copy link
Member

@eaton-coreymutter eaton-coreymutter commented Jan 14, 2025 •
edited
Loading

Closes: #4769

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?) (it doesn't seem like this needs a mention in docs)

Testing Instructions

New Dependency Instructions (If applicable)

@eaton-coreymutter
Copy link
Member Author

I have manually tested the Postgres implementation in a recent container-set, and the Redis implementation in our internal codebase.
Currently writing unit tests to add to this PR, and test auomation for our internal codebase.
Posting as a draft to make sure I'm on the right track with this style of implementation.

@eaton-coreymutter
Copy link
Member Author

Added unit tests and I think this is ready.

@eaton-coreymutter eaton-coreymutter marked this pull request as ready for review January 16, 2025 01:44
@eaton-coreymutter
fix: gofmt
be211cd 
Signed-off-by: Corey Mutter <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Core Metadata] Add "parent" field to Device objects
1 participant
@eaton-coreymutter