Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Community Usage's tooltip position #210

Open
HagerDakroury opened this issue Jun 3, 2021 · 7 comments
Open

Fix Community Usage's tooltip position #210

HagerDakroury opened this issue Jun 3, 2021 · 7 comments
Labels

Comments

@HagerDakroury
Copy link
Collaborator

Specification

Devices

Laptop

Browser

Chrome, Firefox

Message

The tooltip associated with community usage is placed awkwardly

Steps to reproduce:

  1. open the EDAM browser on fullscreen
  2. click on any term (e.g https://edamontology.github.io/edam-browser/#format_3326)
  3. hover over the community Usage title in the details panel

tooltipPosition

@manikmmalhotra
Copy link

hey @HagerDakroury can i work on this issue?

@HagerDakroury
Copy link
Collaborator Author

hi @manikmmalhotra , go ahead!

@manikmmalhotra
Copy link

hey i completed my setup and i dig the problelm and i found a solution i tried and it looks like this,Annotation 2021-08-03 220831
can you suggest me if its alright then i'll make the pull request

@HagerDakroury
Copy link
Collaborator Author

hi @manikmmalhotra, great job! this looks good.
Please, feel free to open a PR right away.

@bryan-brancotte
Copy link
Member

hi @manikmmalhotra

Thanks for tackling this issue, I have some remarks with your solution of #228. By removing the colspan you narrowed the problem: indeed the element containing the text is too large when using bootstrap tooltip (wasn't the case if title="blabla"), but now one can clearly see that a cell is missing.
Sans titre
Also this solution reduce the space for the second column, so removing colspan is not the good approach. Finally, and surprisingly the margin:40% seems to have no effect in my Chrome.

I recommend you to observe if the issue appears elsewhere in the app, and if not, see how was it solved. Also you can simply find a better fix. Up tu you :o)

@manikmmalhotra
Copy link

manikmmalhotra commented Aug 3, 2021

hey @bryan-brancotte sorry as i just checked the code and i made this mistake it's width:40% and this is working fine in any browser sorry for the inconvenience

also the problem with tooltip is it'll be showing at the mid of the total width and i tried to change the tooltip position by changing the tooltipX variable in tree-edam-stand-alone.js so i have to reduce the width of the component to show make the tooltip within range

should i update my mistake and make another pull request
or do you have some suggestion for me

@bryan-brancotte
Copy link
Member

Hi @manikmmalhotra
Indeed with with:40% I see an effect ! Although this solution cause some space to be "lost": look at the blank space "between" the columns.
colspan=2
Capture d’écran de 2021-08-05 10-30-08
width:40%
Capture d’écran de 2021-08-05 10-30-18

I suggest you to dive into the code to search at another place where this issue is fixed. As you can see the tooltip is working great for "Term":
Sans titre

Do not hesitate to propose a new solution, or ask me one. I neither want to waste your time nor spoiling the question on how to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants