improve integration between VariableRegistry and AI VariableService #14827
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #14817
What it does
Note: the ticket was about integrating the AI Variable Service with the Theia VariableRegistry (ideally reusing the VariableRegistry directly for AI). However, there are some key differences between the two:
Moreover, the AI Variable Service already includes a Contribution that delegates to the VariableRegistry in the browser, so no additional work is required here. I made the TheiaVariableContribution a bit easier to replaced (by binding it to self), but actual use cases for customization are unclear at this point, so I don't know how relevant this is.
How to test
Follow-ups
Breaking changes
Attribution
Review checklist
Reminder for reviewers