-
Notifications
You must be signed in to change notification settings - Fork 737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JFR can invoke VM.setJFRRecordingFileName() before VM.startJFR() #21070
Open
JasonFengJ9
wants to merge
1
commit into
eclipse-openj9:master
Choose a base branch
from
JasonFengJ9:jfrjcmd
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+19
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tajila
reviewed
Feb 5, 2025
jcl/src/java.base/share/classes/openj9/internal/tools/attach/target/DiagnosticUtils.java
Outdated
Show resolved
Hide resolved
tajila
reviewed
Feb 5, 2025
jcl/src/java.base/share/classes/openj9/internal/tools/attach/target/DiagnosticUtils.java
Show resolved
Hide resolved
Allow VM.setJFRRecordingFileName() to be invoked before VM.startJFR(); Ignore the recording filename changing within the commands JFR.dump and JFR.stop commands. Signed-off-by: Jason Feng <[email protected]>
tajila
approved these changes
Feb 5, 2025
jenkins test sanity.functional alinux64 jdk21 |
tajila
reviewed
Feb 5, 2025
jcl/src/java.base/share/classes/openj9/internal/tools/attach/target/DiagnosticUtils.java
Show resolved
Hide resolved
A known issue |
jenkins test sanity.functional alinux64 jdk21 |
jenkins test sanity.functional xlinux jdk11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JFR can invoke
VM.setJFRRecordingFileName()
beforeVM.startJFR()
Allow
VM.setJFRRecordingFileName()
to be invoked beforeVM.startJFR()
;Ignore the changing of the recording filename within the commands
JFR.dump
andJFR.stop
.Related to
Signed-off-by: Jason Feng [email protected]