Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate ValuePropogation paths for with and without off-heap #7333

Open
rmnattas opened this issue May 10, 2024 · 0 comments
Open

Consolidate ValuePropogation paths for with and without off-heap #7333

rmnattas opened this issue May 10, 2024 · 0 comments

Comments

@rmnattas
Copy link
Contributor

rmnattas commented May 10, 2024

While adding support for the off-heap feature, a separate path was added in value propagation to handle array transformations for off-heap.
This can be consolidated by using the added array transformation APIs but the array-lets runs reach the same path unexpectedly and causes the JVM to crash. Hence the addition of a separate path for offheap while keeping non-offheap code the same.

Consolidating opportunities:

  • generateArrayTranslateNode
  • generateLenForArrayCopy
  • generateArrayAddressTree

Reference: #7296 (comment)

Original commit that concolidate the paths: rmnattas@ed01b6d
Updated commit using separate paths: rmnattas@29e0c01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant