From 6af1f65f9dad88a162b9d72fa3c9b7bd3a7f82ce Mon Sep 17 00:00:00 2001
From: Pirmin Mattmann <pimattmann@gmail.com>
Date: Tue, 9 Jul 2024 19:26:00 +0200
Subject: [PATCH] fixes according to review

---
 api/fixtures/checklistItems.yml                 | 3 ---
 api/migrations/schema/Version20240620143000.php | 2 +-
 api/src/Entity/Checklist.php                    | 2 +-
 3 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/api/fixtures/checklistItems.yml b/api/fixtures/checklistItems.yml
index 3892d00a438..ffe2553f24f 100644
--- a/api/fixtures/checklistItems.yml
+++ b/api/fixtures/checklistItems.yml
@@ -9,9 +9,6 @@ App\Entity\ChecklistItem:
     checklist: '@checklist1'
     parent: '@checklistItem1_1_2'
     text: 'Camp1_List1_Item2_Item3'
-# checklist2WithNoItems:
-#   checklist: '@checklist2WithNoItems'
-#   text: 'Camp1_List2_Item1'
   checklistItem2_1_1:
     checklist: '@checklist1camp2'
     text: 'Camp2_List1_Item1'
diff --git a/api/migrations/schema/Version20240620143000.php b/api/migrations/schema/Version20240620143000.php
index d6c0c34edf7..1d61764ed09 100644
--- a/api/migrations/schema/Version20240620143000.php
+++ b/api/migrations/schema/Version20240620143000.php
@@ -29,6 +29,6 @@ public function up(Schema $schema): void {
 
     public function down(Schema $schema): void {
         // this down() migration is auto-generated, please modify it to your needs
-        $this->addSql('DELETE FROM public.content_type WHERE id IN (\'a4211c11211c\')');
+        $this->addSql("DELETE FROM public.content_type WHERE id IN ('a4211c11211c')");
     }
 }
diff --git a/api/src/Entity/Checklist.php b/api/src/Entity/Checklist.php
index 9a5ba7fd2c2..9703f5d30ab 100644
--- a/api/src/Entity/Checklist.php
+++ b/api/src/Entity/Checklist.php
@@ -102,7 +102,7 @@ class Checklist extends BaseEntity implements BelongsToCampInterface, CopyFromPr
     #[Assert\NotBlank]
     #[Assert\Length(max: 32)]
     #[ORM\Column(type: 'text')]
-    public ?string $name = null;
+    public string $name;
 
     public function __construct() {
         parent::__construct();