Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPIKE: Lerna/Nx can hide important build problems of individual packages. #2997

Open
ac10n opened this issue Jun 19, 2024 · 1 comment
Open
Labels
dependencies Pull requests that update a dependency file house keeping Chores related to keeping a clean codebase

Comments

@ac10n
Copy link
Contributor

ac10n commented Jun 19, 2024

Consider the following command: npm run build which translates (in package.json) to: nx run-many --target=build --exclude=@taquito/website,taquito-test-dapp-vite outputs the following:
image

But then if we build an individual package separately: npm run build -w packages/taquito-michelson-encoder we can see:
image

Please note that the build problems are masked in the nx run.

There are two problems with this:

  • If it's not caught when developing and merges into master, the released files could be defective
  • It can lead to problems that are difficult to debug (because the developer thinks the build is working) when developing
@dsawali dsawali added dependencies Pull requests that update a dependency file house keeping Chores related to keeping a clean codebase labels Jun 20, 2024
@dsawali dsawali added this to the v20+ milestone Jun 20, 2024
@ac10n ac10n moved this to To do in Taquito Dev Jun 21, 2024
@dsawali dsawali modified the milestones: v20+, 20.1 Jul 17, 2024
@dsawali
Copy link
Contributor

dsawali commented Jul 17, 2024

Seeing that the michelson-encoder package is naturally a recursive package, it might be a bit more difficult to fix the circular dependencies. I would suggest starting from other packages first since they are much easier to solve with taquito-core

@hui-an-yang hui-an-yang removed this from Taquito Dev Oct 2, 2024
@hui-an-yang hui-an-yang removed this from the 20.1 milestone Oct 2, 2024
@github-project-automation github-project-automation bot moved this to Needs triage in Taquito Triage Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file house keeping Chores related to keeping a clean codebase
Projects
Status: Needs triage
Development

No branches or pull requests

3 participants