Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong start bit for auth info signal #833

Open
Patryk-97 opened this issue Jan 16, 2025 · 2 comments
Open

Wrong start bit for auth info signal #833

Patryk-97 opened this issue Jan 16, 2025 · 2 comments
Labels

Comments

@Patryk-97
Copy link

Patryk-97 commented Jan 16, 2025

Since auth info/freshness signal is encoded in Motorola byte order format then start bit should indicate to most significant bit. But in the code start bit points to least significant bit:

start_bit = int(ipdu_length, 0)*8 + int(freshness_tx_length, 0) + int(auth_tx_length, 0) - 8,

start_bit = int(ipdu_length, 0)*8 + int(freshness_tx_length, 0) - 8,

@xRowe are you sure it's correct?

@xRowe
Copy link
Contributor

xRowe commented Jan 23, 2025

Thanks for your feedback

I validate on CANoe, it should be OK now
Please Try xRowe:Fix_#833

@Patryk-97
Copy link
Author

Patryk-97 commented Jan 27, 2025

Hello @xRowe & @ebroecker. Thanks for answer, but still it's not what I meant. Freshness and auth info signals are encoded in Motorola byte order format. So start bit of those signals indicates to most significant bit. So start bit of freshness signal should be:
start_bit = int(ipdu_length, 0)*8 + 7 (assuming it exists)

And start bit of auth info signal should be:
start_bit = int(ipdu_length, 0)*8 + int(freshness_tx_length, 0) + 7

Reference to AUTOSAR system template: https://www.autosar.org/fileadmin/standards/R22-11/CP/AUTOSAR_TPS_SystemTemplate.pdf

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants