Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Moodle Media Bc player with Atto Brightcove. #10

Open
sahedbs23 opened this issue Mar 3, 2022 · 0 comments
Open

Merge Moodle Media Bc player with Atto Brightcove. #10

sahedbs23 opened this issue Mar 3, 2022 · 0 comments
Labels
enhancement New feature or request
Milestone

Comments

@sahedbs23
Copy link
Contributor

This plugin (media_bcplayer) doesn't appear to actually be a Moodle media plugin at all - all the plugin appears to be doing is overriding the header of all pages and injecting some custom JS into the header of all pages. It still contains the weird observer.php class (which I don't think is actually doing anything so should just be deleted.)

It seems to me that you could build this all into the atto_brightcove plugin by adding a before_standard_html_head or before_footer callback to the atto_brightcove lib.php file.

for now as the observer class is still in place, and the fact this plugin doesn't actually appear to be implemented as a media player plugin in moodle I'm going to flag it as requiring more work.

The good news is that I'm happy with the atto_brightcove plugin code at the moment, so if you move the brightcove JS from this media plugin into the atto_brightcove plugin this might be ready to go without needing a lot more time to review.

thanks for your patience with the review process!

@sahedbs23 sahedbs23 added the enhancement New feature or request label Mar 3, 2022
@sahedbs23 sahedbs23 added this to the release-v1 milestone Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant