You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This plugin (media_bcplayer) doesn't appear to actually be a Moodle media plugin at all - all the plugin appears to be doing is overriding the header of all pages and injecting some custom JS into the header of all pages. It still contains the weird observer.php class (which I don't think is actually doing anything so should just be deleted.)
It seems to me that you could build this all into the atto_brightcove plugin by adding a before_standard_html_head or before_footer callback to the atto_brightcove lib.php file.
for now as the observer class is still in place, and the fact this plugin doesn't actually appear to be implemented as a media player plugin in moodle I'm going to flag it as requiring more work.
The good news is that I'm happy with the atto_brightcove plugin code at the moment, so if you move the brightcove JS from this media plugin into the atto_brightcove plugin this might be ready to go without needing a lot more time to review.
thanks for your patience with the review process!
The text was updated successfully, but these errors were encountered:
This plugin (media_bcplayer) doesn't appear to actually be a Moodle media plugin at all - all the plugin appears to be doing is overriding the header of all pages and injecting some custom JS into the header of all pages. It still contains the weird observer.php class (which I don't think is actually doing anything so should just be deleted.)
It seems to me that you could build this all into the atto_brightcove plugin by adding a before_standard_html_head or before_footer callback to the atto_brightcove lib.php file.
for now as the observer class is still in place, and the fact this plugin doesn't actually appear to be implemented as a media player plugin in moodle I'm going to flag it as requiring more work.
The good news is that I'm happy with the atto_brightcove plugin code at the moment, so if you move the brightcove JS from this media plugin into the atto_brightcove plugin this might be ready to go without needing a lot more time to review.
thanks for your patience with the review process!
The text was updated successfully, but these errors were encountered: