Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request : drop node-sass, adopt vite as build tool for development #21

Open
pratik-kanthi opened this issue Mar 29, 2022 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@pratik-kanthi
Copy link
Collaborator

Proposal

  1. Drop node-sass as the sass loader. ( this enables point 2 )
  2. Adopt vite as the package bundler ( for projects that use this package )

Why drop node-sass?

node-sass is now deprecated. Node versions >14 fails to compile this package.
https://sass-lang.com/blog/libsass-is-deprecated

Why Vite?

It's a 100x faster than vue-cli-service !!!.

Dev server starts up instantly.

https://vuejsdevelopers.com/2020/12/07/vite-vue-cli/

Vite provides native ES6 modules which the browser can load without a compilation step.
We cannot currently use Vite with vue9_components because it uses node-sass. Vite doesn't support node-sass.

Vite can build for production too. However, we can continue using webpack for production.

@pratik-kanthi pratik-kanthi added the enhancement New feature or request label Mar 29, 2022
@pratik-kanthi
Copy link
Collaborator Author

Who's the maintainer here? No response in 15 days! 😛

@e9-skanthi
Copy link
Contributor

@pratik-kanthi node-sass is a dev dependency of vue9_components. Can we allow users to choose their own bundler by not installing these dev dependencies?

@pratik-kanthi
Copy link
Collaborator Author

@e9-skanthi unsure what you mean
I'd like Vue9 to be compatible with Vite which requires using dart-sass instead of node-sass as the sass-loader.
Vue9 won't function without a sass loader.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants