Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button: add a nativeType for submit since current type is being used for primary,secondary etc. #16

Open
1 of 2 tasks
sharvilak11 opened this issue Jun 25, 2021 · 0 comments

Comments

@sharvilak11
Copy link

sharvilak11 commented Jun 25, 2021

Can't manually set type="submit" on the button since type prop is being set for something else. This is not ideal since attrs should be treated as attrs. You can do something like v-bind="$attrs" but then type is meant for something else that is reset, submit, button. But this is not worth changing type prop since it would be breaking change.

I would recommend having nativeType as well as support for attrs with v-bind="$attrs" in this component, since it's a basic form level component.

Type of Issue

  • Bug fix
  • New feature

Expected Behavior

Current Behavior

Possible Solution

Add a new prop for now nativeType.

But when major release is done, remove type and rename it as something else so that attrs and props don't clash.

Steps to Reproduce

Context (Environment)

http://reiyoshizawa.com/vue-listeners-attrs/

Detailed Description

Possible Implementation

http://reiyoshizawa.com/vue-listeners-attrs/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant