Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enumeration processing: HL-AST stage #10

Closed
wants to merge 18 commits into from
Closed

Enumeration processing: HL-AST stage #10

wants to merge 18 commits into from

Conversation

AlixANNERAUD
Copy link
Contributor

According to issue #6, can you give me some initial feedback on what I did?

voltangle
voltangle requested changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@voltangle voltangle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! But some changes here and there are needed
When I will get somewhere where I can pull out my laptop, I will try running this
Thanks for contributing m8!

src/main.rs Outdated Show resolved Hide resolved
src/process/enumeration.rs Outdated Show resolved Hide resolved
src/process/enumeration.rs Outdated Show resolved Hide resolved
src/process/enumeration.rs Outdated Show resolved Hide resolved
src/process/enumeration.rs Outdated Show resolved Hide resolved
src/process/mod.rs Show resolved Hide resolved
@voltangle
Copy link
Contributor

Ran the code, and it is broken on the typedef part: it crashes for some reason

@voltangle voltangle changed the title Enumeration processing Enumeration processing: HL-AST stage Jan 26, 2024
@voltangle voltangle linked an issue Jan 26, 2024 that may be closed by this pull request
Make HL-AST processor for enums #6
Open
@voltangle voltangle marked this pull request as draft January 27, 2024 14:02
@AlixANNERAUD AlixANNERAUD marked this pull request as ready for review January 29, 2024 09:44
This was referenced Jan 31, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@voltangle voltangle Awaiting requested review from voltangle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make HL-AST processor for enums
2 participants
@AlixANNERAUD @voltangle