Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

walk does not work on certain server #3

Open
VincenzoLaSpesa opened this issue May 26, 2015 · 5 comments
Open

walk does not work on certain server #3

VincenzoLaSpesa opened this issue May 26, 2015 · 5 comments

Comments

@VincenzoLaSpesa
Copy link
Contributor

The walk function works correctly on server with standard behaviour.
for example ftp://bo.mirror.garr.it/
It outputs line formatted like this

    modify=20081125111318;perm=adfr;size=24;type=OS.unix=symlink;unique=FE0BU200059DA;UNIX.group=0;UNIX.mode=0777;UNIX.owner=0; linux

But certain servers ( like ftp://ftp.packardbell.com/ ) produces output like this:

    -rw-r--r--   1 aokur    (?)            17 Jan  5  2010 fcheck.js

Looking at func (ftp *FTP) List(path string) I see that you first try to use MLSD and if it don't work fall back to LIST

There are some other command that produce output more parsable than LIST.

like NLST or EPLF

@nl5887
Copy link
Member

nl5887 commented May 29, 2015

This issue can be closed because of PR #4 right?

@VincenzoLaSpesa
Copy link
Contributor Author

Not yet.
I'll have to write a parser for NLST and EPLF in order to cover more type of server.

(I forgot to add a test case for "walk", it works only on goodServer)

@jangler
Copy link
Contributor

jangler commented Aug 30, 2015

Anyone still working on this? If not, I'm about to tackle it.

@VincenzoLaSpesa
Copy link
Contributor Author

I'm on it.
My fork works. I'll have to write a couple of test cases, update docs, and arrange a pull request.
https://github.com/VincenzoLaSpesa/goftp

@nl5887
Copy link
Member

nl5887 commented Aug 31, 2015

That would be great @VincenzoLaSpesa. Currently don't have a lot of time, but will spend some time next weeks to improve quality and tests also.

zaz600 pushed a commit to zaz600/goftp that referenced this issue Jan 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants