Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix serde implementation #145

Open
Neotamandua opened this issue Dec 13, 2024 · 0 comments
Open

Fix serde implementation #145

Neotamandua opened this issue Dec 13, 2024 · 0 comments
Assignees
Labels
fix:bug Something isn't working

Comments

@Neotamandua
Copy link
Member

Neotamandua commented Dec 13, 2024

Summary

The current serde implementation is inconsistent with our other serialization & deserialization implementationse. This is especially important for Scalar which is also in some events on execution-core that support serde json representations.

Possible solution

Examine the differences in how the types of this crate implement Serialize & Deserialize with serde vs. the other serde serialization implementations we now have - and align them properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants