From cf44b5dc30a227d2514568d2ae096ce740dd6dab Mon Sep 17 00:00:00 2001 From: Josh Leibstein Date: Fri, 5 Jul 2024 22:57:28 +0200 Subject: [PATCH] Fix ViewModels IllegalStateException (#4720) Task/Issue URL: https://app.asana.com/0/1200204095367872/1207733727777585/f ### Description Only executes tab hidden/shown logic if the fragment is attached. ### Steps to test this PR - [ ] Code review. --- .../main/java/com/duckduckgo/app/browser/BrowserTabFragment.kt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/src/main/java/com/duckduckgo/app/browser/BrowserTabFragment.kt b/app/src/main/java/com/duckduckgo/app/browser/BrowserTabFragment.kt index b64aa57efd05..b1eb612fec6a 100644 --- a/app/src/main/java/com/duckduckgo/app/browser/BrowserTabFragment.kt +++ b/app/src/main/java/com/duckduckgo/app/browser/BrowserTabFragment.kt @@ -2924,12 +2924,14 @@ class BrowserTabFragment : } private fun onTabHidden() { + if (!isAdded) return viewModel.onViewHidden() downloadMessagesJob.cancel() webView?.onPause() } private fun onTabVisible() { + if (!isAdded) return webView?.onResume() launchDownloadMessagesJob() viewModel.onViewVisible()