Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance TCI use case to be flexible for other models besides CESM #2575

Open
23 tasks
DanielAdriaansen opened this issue May 6, 2024 · 3 comments · May be fixed by #2768
Open
23 tasks

Enhance TCI use case to be flexible for other models besides CESM #2575

DanielAdriaansen opened this issue May 6, 2024 · 3 comments · May be fixed by #2768
Assignees
@DanielAdriaansen @georgemccabe
Labels
priority: high High Priority requestor: University/other University Collaborator, not otherwise specified type: enhancement Improve something that it is currently doing
Milestone
METplus-6.1.0

Comments

@DanielAdriaansen
Copy link
Contributor

DanielAdriaansen commented May 6, 2024 •
edited by georgemccabe
Loading

Describe the Enhancement

In #2388, this use case was updated to use raw FLUXNET observations to compute TCI. Some refinements were made to the use case config file as well, but the names selected for configuration items are specific to CESM. This issue is to generalize the config items and add documentation for the use case describing how a user would modify the config file to work for their model. The changes should be specific to items related to computing TCI only, and not about file formats, grids, or other config options that are specific to the users' model.

We should also at the same time:

  • Add the season being processed to the DESC column so a user can filter output in downstream tools by season
  • Consider why POINT_STAT_OBS_VALID_BEG and OBS_VALID_BEG are being used. POINT_STAT_OBS_VALID_BEG is provided on the command line and overrides OBS_VALID_BEG.

Time Estimate

4 hours

Funding Source

UWCIMSS Otkin Drought 2785031

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED CYCLE ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Add any new Python packages to the METplus Components Python Requirements table.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@DanielAdriaansen DanielAdriaansen added the type: enhancement Improve something that it is currently doing label May 6, 2024
@DanielAdriaansen DanielAdriaansen added this to the METplus-6.0.0 milestone May 6, 2024
@DanielAdriaansen DanielAdriaansen self-assigned this May 6, 2024
@DanielAdriaansen
Copy link
Contributor Author

@anewman89 we will need to discuss how to handle Python embedding. During the land project meeting last week, I forgot that the Python script used to derive TCI from the FCST is somewhat specific for CESM. Notably, it assumes:

  1. NetCDF file format
  2. Dimensions of time, lat, and lon
  3. Time units of days since YYYY-MM-DD HH:MM:SS

Otherwise, the Python script cesm_tci.py should work. I think for UFS, the kicker might be NetCDF format, because maybe the UFS data are GRIBv2?

@JohnHalleyGotway JohnHalleyGotway added requestor: University/other University Collaborator, not otherwise specified priority: high High Priority labels May 15, 2024
@JohnHalleyGotway JohnHalleyGotway moved this from 🔖 Ready to 🏗 In progress in METplus-Wrappers-6.0.0 Development May 15, 2024
@DanielAdriaansen
Copy link
Contributor Author

Added two additional suggestions to refine the use case made during dtcenter/MET#2897.

@anewman89
Copy link

@DanielAdriaansen - You're correct. UFS and potentially other models are going to be in GRIB. I'm forgetting if we had discussed other paths forward at the last land meeting, or elsewhere... I think based on our discussions of the idea of use cases not being all encompassing we might want to consider the following: Let's make a project specific python embedding script that can read UFS data and then follow this use case outcomes, but leave it offline. If we later think a GRIB specific TCI use case is warranted, we could re-open this issue.

For funding this issue and/or the offline python scripting to read UFS data, we should move to the Dyn Drought Veg project now.

georgemccabe added a commit that referenced this issue Nov 4, 2024
@georgemccabe
per #2575, rename variables, scripts, etc. to avoid using model-speci…
d54e898 
…fic wording to encourage users to modify this use case to use other models
@georgemccabe georgemccabe linked a pull request Nov 4, 2024 that will close this issue
Feature #2575 TCI use case - generic model #2768
Draft
16 tasks
@georgemccabe georgemccabe moved this from 🏗 In progress to 🔎 In review in METplus-Wrappers-6.0.0 Development Nov 4, 2024
@DanielAdriaansen DanielAdriaansen moved this from 🩺 Needs Triage to 🔎 In review in METplus-Wrappers-6.1.0 Development Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DanielAdriaansen DanielAdriaansen

@georgemccabe georgemccabe

Labels
priority: high High Priority requestor: University/other University Collaborator, not otherwise specified type: enhancement Improve something that it is currently doing
Projects
METplus-Wrappers-6.1.0 Development
Status: 🔎 In review
Milestone
METplus-6.1.0
Development

Successfully merging a pull request may close this issue.

Feature #2575 TCI use case - generic model dtcenter/METplus
4 participants
@anewman89 @DanielAdriaansen @JohnHalleyGotway @georgemccabe