Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: Deprecate master_metplus.py #2714

Closed
1 of 24 tasks
georgemccabe opened this issue Oct 4, 2024 · 0 comments · Fixed by #2730
Closed
1 of 24 tasks

Enhancement: Deprecate master_metplus.py #2714

georgemccabe opened this issue Oct 4, 2024 · 0 comments · Fixed by #2730
Assignees
@georgemccabe
Labels
requestor: METplus Team METplus Development Team type: enhancement Improve something that it is currently doing
Milestone
METplus-6.0.0

Comments

@georgemccabe
Copy link
Collaborator

We have been supporting master_metplus.py with a warning message that it will eventually be removed since v4.0.

Describe the Task

Change master_metplus.py to no longer call run_metplus.py with a warning, but instead error and exit, alerting users to call run_metplus.py instead.

Time Estimate

1-2 hours

Sub-Issues

Consider breaking the task down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

v6.0.0

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Review default alert labels
  • Select component(s)
  • Select priority
  • Select requestor(s)

Milestone and Projects

  • Select Milestone as a METplus-Wrappers-X.Y.Z version, Consider for Next Release, or Backlog of Development Ideas
  • For a METplus-Wrappers-X.Y.Z version, select the METplus-Wrappers-X.Y.Z Development project

Define Related Issue(s)

Consider the impact to the other METplus components.

Task Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Add any new Python packages to the METplus Components Python Requirements table.
  • For any new datasets, an entry to the METplus Verification Datasets Guide.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the next official version
    Select: METplus-Wrappers-X.Y.Z Development project for development toward the next official release
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@georgemccabe georgemccabe added type: task An actionable item of work requestor: METplus Team METplus Development Team labels Oct 4, 2024
@georgemccabe georgemccabe added this to the METplus-6.0.0 milestone Oct 4, 2024
@georgemccabe georgemccabe self-assigned this Oct 4, 2024
georgemccabe added a commit that referenced this issue Oct 4, 2024
@georgemccabe
per #2714, deprecate master_metplus.py
de5fa14
georgemccabe added a commit that referenced this issue Oct 15, 2024
@georgemccabe
per #2714, deprecate master_metplus.py
67a9928
@georgemccabe georgemccabe mentioned this issue Oct 15, 2024
Merged
16 tasks
@georgemccabe georgemccabe linked a pull request Oct 15, 2024 that will close this issue
Feature #2727 point_weight_flag and obtype_as_group_val_flag #2730
Merged
16 tasks
georgemccabe added a commit that referenced this issue Oct 16, 2024
@georgemccabe
Feature #2727 point_weight_flag and obtype_as_group_val_flag (#2730)
414be7e 
* Per #2727, add support for setting point_weight_flag

* Per #2727, add support for obtype_as_group_val_flag

* per #2714, deprecate master_metplus.py
@georgemccabe georgemccabe changed the title Deprecate master_metplus.py Enhancement: Deprecate master_metplus.py Oct 18, 2024
@georgemccabe georgemccabe added type: enhancement Improve something that it is currently doing and removed type: task An actionable item of work labels Oct 18, 2024
georgemccabe added a commit that referenced this issue Oct 18, 2024
@georgemccabe
Feature #2682 Component version lookup (#2733)
86327e0 
* per #2714, deprecate master_metplus.py

* exclude metplus/scripts from SonarQube scan to prevent incorrect duplicate code error since script lives in ush

* added Dockerfile to build image with MET/METplus and METplus Analysis Python packages

* start of script to get versions of METplus components

* per #2682, created METplus component version lookup table and functions to get formatted version of requested components

* add descriptions for tests

* add update information and made script callable

* made script executable

* add workflow to trigger on release and create dtcenter/metplus and dtcenter/metplus-analysis Docker images

* add scripts used by new workflow

* removed build hook scripts since we will be building images via GHA

* change logic to get MET version using component version script instead of build hook file that just adds 6 to major version

* add missing shebang

* make script callable directly and make output component a required input

* pass LATEST_TAG to push script

* ensure only 1st line of version file is read to avoid newline

* turn on use case to test

* turn off use case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@georgemccabe georgemccabe

Labels
requestor: METplus Team METplus Development Team type: enhancement Improve something that it is currently doing
Projects
METplus-Wrappers-6.0.0 Development
Status: 🏁 Done
Milestone
METplus-6.0.0
Development

Successfully merging a pull request may close this issue.

Feature #2727 point_weight_flag and obtype_as_group_val_flag dtcenter/METplus
1 participant
@georgemccabe