-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write test utility to search a 3D cloud of points for the nearest neighbor to a specified (lat, lon, elev) location #3012
Labels
MET: UGRID
Issues related to unstructured grid (UGRID) support in MET
priority: high
High Priority
requestor: Navy/NRL
Naval Research Laboratory
type: new feature
Make it do something new
Milestone
Comments
JohnHalleyGotway
added
type: new feature
Make it do something new
requestor: Navy/NRL
Naval Research Laboratory
priority: high
High Priority
MET: UGRID
Issues related to unstructured grid (UGRID) support in MET
labels
Nov 12, 2024
hsoh-u
pushed a commit
that referenced
this issue
Nov 19, 2024
hsoh-u
pushed a commit
that referenced
this issue
Dec 11, 2024
hsoh-u
pushed a commit
that referenced
this issue
Dec 11, 2024
hsoh-u
pushed a commit
that referenced
this issue
Dec 11, 2024
hsoh-u
pushed a commit
that referenced
this issue
Dec 11, 2024
17 tasks
JohnHalleyGotway
pushed a commit
that referenced
this issue
Dec 13, 2024
… test executables in the test_util/libcode/vx_grid directory.
JohnHalleyGotway
pushed a commit
that referenced
this issue
Dec 13, 2024
…mells in New Code and hopefully reduce the Overall number of code smells.
JohnHalleyGotway
pushed a commit
that referenced
this issue
Dec 13, 2024
hsoh-u
added a commit
that referenced
this issue
Dec 13, 2024
* #3012 Initial release * #3012 Added search_3d_kdtree.cc * #3012 Initial release * #3012 Added check_llh_to_ecef and test_llh_to_ecef * #3012Added search_3d_kdtree_api * #3012 Reanmed point_lonlat to points_lonlat. Added points_XYZ & points_XYZ_km * #3012 Compare points_XYZ or points_latlon * #3012 Commented out latlonalt_to_xy & xy_to_latlonalt * #3012 Reanmed point_lonlat to points_lonlat. Added points_XYZ & points_XYZ_km. Added llh_to_ecef APIs * Per #3012, update the .gitignore settings to ignore the newly created test executables in the test_util/libcode/vx_grid directory. * Per #3012, changes to the vx_grid library to address SonarQube code smells in New Code and hopefully reduce the Overall number of code smells. * Per #3012, couple more minor SonarQube tweaks --------- Co-authored-by: Howard Soh <[email protected]> Co-authored-by: MET Tools Test Account <[email protected]>
github-project-automation
bot
moved this from 🔎 In review
to 🏁 Done
in MET-12.1.0 Development
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
MET: UGRID
Issues related to unstructured grid (UGRID) support in MET
priority: high
High Priority
requestor: Navy/NRL
Naval Research Laboratory
type: new feature
Make it do something new
Describe the New Feature
This issue to create a new development utility in the
internal/test_util/libcode/vx_grid
directory named something likesearch_3d_kdtree
.This test utility would:
PointLonLat
class.Usage would look something roughly like this:
Arguments were modified
The purpose of this test utility is to demonstrate that MET can be enhanced to search a 3D cloud for the point closest to a requested location. While the
PointXYZ
class looks promising, please consider other more classes provided by Atlas and ecKit that may be more appropriate.If this utility proves useful, consider reimplementing the existing
unstructured_grid.h/.cc
source code to switch from 2D lat/lon support to 3D lat/lon/elev support. And when processing lat/lon only points, just define the elevation as a constant value.The real challenge here is figuring out the "units" of the coordinate system. We need to clearly define the 3D distance metric. If possible, consider mapping all 3 dimensions into a coordinate system defined in meters (or kilometers) where distances in the horizontal and vertical are well-defined and comparable.
Acceptance Testing
List input data types and sources.
Describe tests required for new functionality.
Time Estimate
Estimate the amount of work required here.
Issues should represent approximately 1 to 3 days of work.
Sub-Issues
Consider breaking the new feature down into sub-issues.
Relevant Deadlines
Do not charge 7730022 after 12/30.
Funding Source
7730022 NRL METplus
Define the Metadata
Assignee
Labels
Milestone and Projects
Define Related Issue(s)
Consider the impact to the other METplus components.
No impacts for this test utility.
New Feature Checklist
See the METplus Workflow for details.
Branch name:
feature_<Issue Number>_<Description>
Pull request:
feature <Issue Number> <Description>
Select: Reviewer(s) and Development issue
Select: Milestone as the next official version
Select: MET-X.Y.Z Development project for development toward the next official release
The text was updated successfully, but these errors were encountered: