Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance make_test to test Python embedding functionality #2788

Open
7 of 22 tasks
jprestop opened this issue Jan 11, 2024 · 0 comments
Open
7 of 22 tasks

Enhance make_test to test Python embedding functionality #2788

jprestop opened this issue Jan 11, 2024 · 0 comments
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle component: build process Build process issue component: testing Software testing issue priority: high High Priority requestor: METplus Team METplus Development Team type: enhancement Improve something that it is currently doing

Comments

@jprestop
Copy link
Collaborator

Describe the Enhancement

In the issue "Suggested Improvements to Python Embedding across MET #2414" the following is suggested:

If --enable_python is used when building, have make_test check if the version of python specified can successfully load all the required packages from a list of required packages that is maintained somewhere.

In addition, it would be good to run a couple of test case to test the functionality of Python embedding, for example, the code that is current failing:

plot_data_plane -v 10 PYTHON_NUMPY fcst.ps 'name="/d1/projects/MET/MET_releases/testing/intel/share/met/python/examples/read_ascii_numpy.py /d1/projects/METplus/METplus_Data/met_test/data/python/fcst.txt FCST";'

Time Estimate

1 to 3 days of work

Sub-Issues

Consider breaking the enhancement down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

TBD

Funding Source

TBD

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Review default alert labels
  • Select component(s)
  • Select priority
  • Select requestor(s)

Milestone and Projects

  • Select Milestone as the next official version or Backlog of Development Ideas
  • For the next official version, select the MET-X.Y.Z Development project

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the next official version
    Select: MET-X.Y.Z Development project for development toward the next official release
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@jprestop jprestop added type: enhancement Improve something that it is currently doing component: build process Build process issue alert: NEED ACCOUNT KEY Need to assign an account key to this issue requestor: METplus Team METplus Development Team priority: high High Priority labels Jan 11, 2024
@jprestop jprestop added this to the MET 12.0.0 milestone Jan 11, 2024
@georgemccabe georgemccabe added component: testing Software testing issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle labels May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle component: build process Build process issue component: testing Software testing issue priority: high High Priority requestor: METplus Team METplus Development Team type: enhancement Improve something that it is currently doing
Projects
None yet
Development

No branches or pull requests

2 participants