Fix for incorrect argument handling in delete accessor of Many association #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… logic as in the add handler
|
Thanks. Could you add a test case? Someone might inadvertantly break it in future if it's not tested.. |
|
I'm going to accept this and add a test. |
dresende
added a commit
that referenced
this pull request
Sep 13, 2013
Fix for incorrect argument handling in delete accessor of Many association
dresende
added a commit
that referenced
this pull request
Sep 13, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The delete accessor of the Many association wasn't correctly handling the removal of several associations when it was passed an array. It set the Associations variable incorrectly, so the conditions were being built wrong and no records were being deleted. I replaced the old argument handling logic with the more robust logic used in the add accessor.