Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons are not dark-mode ready #228

Open
bitigchi opened this issue Mar 21, 2024 · 6 comments
Open

Icons are not dark-mode ready #228

bitigchi opened this issue Mar 21, 2024 · 6 comments

Comments

@bitigchi
Copy link
Contributor

See screenshot:

Ekran Görüntüsü_20240321_165907

Latest master.

@Dan-Sun
Copy link

Dan-Sun commented Mar 27, 2024

The icons are not so bad, but adding something from the catalogs is quite tricky.

There is a similar issue here - #84 (comment)

Edit:
kraft-dark_mode

@dragotin
Copy link
Owner

This summarizes what has to be done for icon sets for bright and dark theme: https://openapplibrary.org/dev-tutorials/qt-icon-themes

I leave that for somebody who wants to contribute to Kraft as a good beginner job. The icons have to be converted to bright color (or can that be done programmatically with SVG?) and added as an alternative theme to the app.

So far, Kraft needs to be run in bright mode.
The question remains how to run a single app like kraft in bright mode while the desktop is in dark mode. That would be a workaround.

@Andreas-Kainz
Copy link

As an old maintainer of breeze icons and contributor to libreoffice icon themes, I can support you with icons if needed. I also helped collaboreonline with dark mode support.

@dragotin
Copy link
Owner

thank you very much @Andreas-Kainz for the offer. I haven't investigated too much into what has to be done to make a dark theme work properly. What do you suggest how to start? Where would you need my help?

@Andreas-Kainz
Copy link

Andreas-Kainz commented Oct 12, 2024

Thanks for your feedback @dragotin I will have a look how to setup everything. Ordinary I didn't have to build everything so it should be not to complicated. When I need something, I will ask.

Can someone assigne me to the bug.

@Andreas-Kainz
Copy link

where will the custom-icons be installed ordinary on ubuntu or linux? I search the complete system after the svg files, but didn't find them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants