Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ParentSelector #936

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

baowj-678
Copy link
Contributor

Description

add ParentSelector

Related Issue

dragonflyoss/dragonfly#3713

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)
    Checklist
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@baowj-678 baowj-678 requested a review from a team as a code owner January 9, 2025 03:30
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 0% with 119 lines in your changes missing coverage. Please review.

Project coverage is 32.27%. Comparing base (d4096db) to head (a0c64c0).

Files with missing lines Patch % Lines
dragonfly-client/src/resource/parent_selector.rs 0.00% 118 Missing ⚠️
dragonfly-client/src/grpc/dfdaemon_upload.rs 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #936      +/-   ##
==========================================
- Coverage   32.66%   32.27%   -0.40%     
==========================================
  Files          60       61       +1     
  Lines        9792     9911     +119     
==========================================
  Hits         3199     3199              
- Misses       6593     6712     +119     
Files with missing lines Coverage Δ
dragonfly-client/src/grpc/dfdaemon_upload.rs 0.00% <0.00%> (ø)
dragonfly-client/src/resource/parent_selector.rs 0.00% <0.00%> (ø)

Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add self-test video.

@@ -1580,6 +1580,17 @@ impl DfdaemonUploadClient {
Ok(response.into_inner())
}

/// sync_pieces provides the piece metadata for parent.
#[instrument(skip_all)]
pub async fn sync_host(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move to PR: #929.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants