Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement functionality to work with multiple databases #43

Closed
famosab opened this issue Nov 3, 2022 · 3 comments
Closed

Implement functionality to work with multiple databases #43

famosab opened this issue Nov 3, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@famosab
Copy link
Member

famosab commented Nov 3, 2022

Is your feature request related to a problem? Please describe.
Multiple databases like KEGG and BiGG are referenced and used within refineGEMs but sometimes functions overlap or duplicate and the databases are not updated.

Describe the solution you'd like
Something triggered by the user which leads to a one-time download (the MCC tool does that) which can be reused or updated.

Maybe this can be bundled into a submodule databases.py which takes care of downloading and then parsing as well as formatting so that these databases can be used by a refineGEMs user and within the scripts provided by refineGEMs. (see #31, #28)

@famosab
Copy link
Member Author

famosab commented Nov 4, 2022

See #36. Rough changes are already implemented but this can surely be extended.

@GwennyGit
Copy link
Collaborator

As a suggestion, the enhancement of the SBO annotation module as described in issue draeger-lab/SBOannotator#1 could be also handled by the database.py submodule.

GwennyGit added a commit that referenced this issue Aug 21, 2023
The function get_model_reacs_or_metabs now takes a new parameter. If the model's metabolites/reactions are not from the BiGG namespace the parameter col_name can now be changed to  a user-specific string. To not break the original code, col_name is by default set to 'bigg_id'.
@GwennyGit
Copy link
Collaborator

As the main aim of this issue, namely downloading and maintaining the different databases used within refineGEMs in one place, is already implemented, this issue can be closed. Furthermore, enhancing refineGEMs through the usage of more databases is already handled or mentioned in more detail in issue #36, and the storage question of these databases is already mentioned in more detail in issue #49. Thus, I will close this issue as completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants