Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Add makefile #200

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

[WIP] Add makefile #200

wants to merge 4 commits into from

Conversation

ran-dall
Copy link
Contributor

@ran-dall ran-dall commented Jun 20, 2022 •
edited
Loading

Please Don't ship WIP

Closes #199 #170

This PR adds a makefile with the preferred end-user deployment configuration.

This make file currently has 2 options (more options may be added later):

gnome-40 : Switch to the right gnome-shell.css file and deploys files and folders for libadwaita compatibility on GNOME 40+.
prune : Deletes superfluous folders (i.e. will delete KDE, if not using KDE; GNOME if not using GNOME; etc...).

@ran-dall ran-dall changed the title Add makefile WIP Add makefile Jun 20, 2022
@ran-dall ran-dall changed the title WIP Add makefile [WIP] Add makefile Jun 20, 2022
@ran-dall ran-dall marked this pull request as draft June 20, 2022 19:51
@vivshaw
Copy link

vivshaw commented Jun 27, 2022

👍 on this- I had trouble with my upgrade to Gnome 42, and these gnome-40 build steps fixed it! But they aren't clearly documented elsewhere, and are difficult to find by digging through GitHub issues. It'd be nice to have some sort of built-in script like this (or barring that, to add least add these steps to the docs)

@ran-dall
Copy link
Contributor Author

+1 on this- I had trouble with my upgrade to Gnome 42, and these gnome-40 build steps fixed it!

@vivshaw Awesome! Super glad it helped. I was hoping to get this kind of feedback. 😁

But they aren't clearly documented elsewhere, and are difficult to find by digging through GitHub issues.

Good point. I will make sure to modify the docs and README in this PR so that it is properly notated and documented.

Thanks again for the feedback! 🤝

@ran-dall
Update Glup (and friends), along with Gulpfile.js and package.json
b2314bf 
The package.json's dependencies were heavily out of date. Not to mention, that it was also missing a lot of basic information.

This commit brings the dependencies up-to-date and updates the package.json.
@ran-dall
Update Gulpfile.js to work with gtk-4.0 styles
484b940
@ran-dall ran-dall force-pushed the add-makefile branch 3 times, most recently from 588f0e8 to 17c04de Compare August 6, 2022 22:56
This was referenced Aug 8, 2022
Closed
Closed
Closed
@ran-dall ran-dall force-pushed the add-makefile branch 2 times, most recently from 25065ae to fa8b4ed Compare August 8, 2022 08:11
@ran-dall
Compliance fixes for gtk-3.20, gtk-4.0, and gnome-shell
d1c7702 
This commit fixes all immediate errors that would cause `dart-sass` to error out.
@ran-dall
Add makefile
eb136e7
@malcolmturnbull malcolmturnbull mentioned this pull request Sep 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Faciltate end-user installation with a makefile
2 participants
@ran-dall @vivshaw