Highlighting from hl-line-mode and set-mark-command are blending together.

[YueRen]

I believe 62045ab is making the highlighting from hl-line-mode the same as the highlighting from set-mark-command. This means that the highlighting from marking text within a highlighted line becomes invisible, because they blend together seamlessly, which is problematic and very unlike all other emacs themes.

To reproduce:

1. Go to the start of a line with text
2. Activate hl-line-mode using M-x hl-line-mode
3. Activate mark by C-Spc
4. Move curser to the right, notice there are no visible highlighting
5. Move curser up and down, notice how both highlights coincide

[milouse]

Hi, and sorry for the long silence. Thank you very much for your report.

Indeed, on that subject, the change is not good. I wonder if there is something like hl-line-mode on vscode and how they deal with this kind of situation.

I tried to fix that with one of the other (non-canon) background color historically in use in emacs for this theme. Can you check if it does the job, or if I should investigate other color (if possible I’d like to avoid to introduce a new color).

[YueRen]

Thanks for the change, it looks much better now. The highlighting colours (line vs mark) are different now, though it is still a bit difficult to spot:

One suggestion: Would it be possible to increase the brightness of the mark highlight slightly so that the contrast between highlight and background is as strong as in the VS Code screenshot in #106?

Compare

vs (hl-line-mode disabled in screenshot below)

That should automatically improve the readability with hl-line-mode enabled.