-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update checks based on latest webPreferences defaults #58
Comments
I went through https://www.electronjs.org/docs/breaking-changes and looked for all "Default changed" changes. These now respect the Electron version if known.
This is an important feature that we're still missing. This is my design proposal:
This will help us eliminate many version-dependent decisions from every check. |
Thanks to @baltpeter (#66, #67) Electronegativity is getting smarter! 🎉 Things we still need to do before pushing a new version:
|
We're now on Electron 7.x as stable. Since we built our checks - many webPreferences default configs have changed.
E.g. Since v5, nodeIntegration is disabled by default. Our current nodeIntegration checks will trigger a false positive if there's no explicit setting since we still assume that the default is on. I believe the same problem apply to many other checks.
The text was updated successfully, but these errors were encountered: