Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to read electron version in nx-electron #112

Open
KaraboMolemane opened this issue Oct 24, 2024 · 1 comment
Open

Unable to read electron version in nx-electron #112

KaraboMolemane opened this issue Oct 24, 2024 · 1 comment

Comments

@KaraboMolemane
Copy link

KaraboMolemane commented Oct 24, 2024

Describe the bug
The tool is not able to read the electron version on a nx-electron. I assume this is due to the fact that the package.json sits at the root of the nx-monorepo project instead of the nx-electron app.

To Reproduce
Steps to reproduce the behavior:

  1. Create an nx-monorepo project npx create-nx-workspace@18 (https://www.npmjs.com/package/nx-electron/v/18.0.1)
  2. Install [email protected] npm install -D nx-electron
  3. Create a frontend app that nx-electron will point to (https://www.npmjs.com/package/@nx/react)
  4. Create an nx-electron app nx g nx-electron:app <electron-app-name> --frontendProject=<frontend-app-name>
  5. Run the test electronegativity -i <electron-app-name>

The above action will show the message below, indicating that it cannot detect the version

`Starting scan...

Could not retrieve updated translations for the current locale
warn: Couldn't detect Electron version, assuming v0.1.0. Defaults have probably changed for your actual version, please check manually.`

Expected behavior
The expectation is for the correct version to be detected and the relevant tests are executed

**Stacktraces **

Platform (please complete the following information):

  • OS: Win 11
  • Electronegativity version: 1.10.3

Additional context
My project is running on "electron": "^27.3.11",. The test flags REMOTE_MODULE_JS_CHECK which requires enableRemoteModule: false which was deprecated in version 12.

@ikkisoft
Copy link
Contributor

Please note that we're no longer actively maintaining this project. If you want to send a PR request, we will review that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants