Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Media3 migration #2252

Open
lovegaoshi opened this issue Feb 13, 2024 · 4 comments
Open

[Feature Request] Media3 migration #2252

lovegaoshi opened this issue Feb 13, 2024 · 4 comments

Comments

@lovegaoshi
Copy link
Contributor

What is the need and use case of this feature?
android media3 migration

Describe the ideal solution
migrate to media3

Describe alternatives you've considered
not migrate

Additional context
I've been doing a bit of research on this and here's what I've found:

simply changing all the exoplayer2 parts into their exoplayer3 counterparts compiles and runs as expected: my repo
however to fully utilize media3's capabilities (namely the automatic notification/service management via MediaLibraryService) RNTP needs a good amount of work to migrate into the Service-Connector structure. See google's migration commit
Meanwhile I'm still struggling with implementing a MediaLibraryService for KA to show a notification.

How I can Help
What can you do to help get this feature into production?
Can you assist by working on this feature and creating a Pull Request?
working on it
tbh I'm not looking forward to this as the current AA implementation will also need a good amount of refactoring; I'm so confused with "properly" migrating KA that I'm more leaning towards a rewrite based off of UAMP at this point

@lovegaoshi
Copy link
Contributor Author

my biggest uncertainty right now is how to specify UA, as MediaController does not pass MediaSource but MediaItem; seems doable by
androidx/media#125 (comment)

@lovegaoshi
Copy link
Contributor Author

managed to have a barebones KA media3 skeleton:
https://github.com/lovegaoshi/KotlinAudio3

Copy link
Contributor

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label May 20, 2024
Copy link
Contributor

This issue was closed because it has been stalled for 7 days with no activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants