Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NuGetSigner ignores SignAsync return value #798

Open
zooba opened this issue Nov 8, 2024 · 1 comment
Open

NuGetSigner ignores SignAsync return value #798

zooba opened this issue Nov 8, 2024 · 1 comment
Labels
area-nuget Related to NuGet signing area-vsix Related to VSIX signing bug Priority:1 Work that is critical for the release, but we could probably ship without

Comments

@zooba
Copy link

zooba commented Nov 8, 2024

When signing a nupkg fails, RetryingSigner.SignAsync returns false.

However, the NuGetSigner (subclass) which calls this function ignores the result.

As a result, the sign tool exits with exit code 0 and the caller does not know that signing has failed.

@zooba
Copy link
Author

zooba commented Nov 8, 2024

It looks like this also affects VsixSigner.

However, ClickOnceSigner converts the result into a generic exception.

@dtivel dtivel added bug Priority:1 Work that is critical for the release, but we could probably ship without area-nuget Related to NuGet signing area-vsix Related to VSIX signing labels Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-nuget Related to NuGet signing area-vsix Related to VSIX signing bug Priority:1 Work that is critical for the release, but we could probably ship without
Projects
None yet
Development

No branches or pull requests

2 participants