Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review test changes from #43015 #45299

Closed
6 tasks done
Youssef1313 opened this issue Dec 4, 2024 · 3 comments
Closed
6 tasks done

Review test changes from #43015 #45299

Youssef1313 opened this issue Dec 4, 2024 · 3 comments
Assignees
Milestone

Comments

@Youssef1313
Copy link
Member

Youssef1313 commented Dec 4, 2024

Part of the changes from #43015 are being reverted as part of #45295 as they were not correct. Some other tests are ignored but that's tracked by #42850

There are more changes that may need to be reviewed by the SDK team:

NOTE: It's possible that some of the test changes are not wrong per-se and are temporary until other parts of the ecosystem release their stuff. In that case it's still good to have a tracking issue to revert when the time comes

cc @baronfel

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-DotNet Test untriaged Request triage from a team member labels Dec 4, 2024
@Forgind Forgind added needs team triage Requires a full team discussion and removed untriaged Request triage from a team member labels Dec 10, 2024
@marcpopMSFT
Copy link
Member

@v-wuzhai do you mind taking a look at this and see if there are any here that you can sort out and resolve?

@marcpopMSFT marcpopMSFT removed the needs team triage Requires a full team discussion label Dec 10, 2024
@marcpopMSFT marcpopMSFT added this to the 10.0.1xx milestone Dec 10, 2024
@v-wuzhai
Copy link
Member

These changes are primarily to support the transition from .NET 9.0 to .NET 10.0. We have updated the test frameworks and related code to ensure compatibility and validate new features in the latest version. However, these changes might be temporary, and we will gradually revert them as other parts of the ecosystem release their updates.

@v-wuzhai
Copy link
Member

v-wuzhai commented Jan 8, 2025

Given that all related issues are being tracked and addressed separately, this PR will be closed.

@v-wuzhai v-wuzhai closed this as completed Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants