Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new IndexOfAnyValues in RegexCompiler and source generator #78203

Closed
stephentoub opened this issue Nov 11, 2022 · 2 comments · Fixed by #78927
Closed

Use new IndexOfAnyValues in RegexCompiler and source generator #78203

stephentoub opened this issue Nov 11, 2022 · 2 comments · Fixed by #78927

Comments

@stephentoub
Copy link
Member

Once #78093 is merged, we'll want to use it in the RegexCompiler and source generator. This will require reworking the heuristics for when we consider sets viable for being used with IndexOf, updating the relevant data structures to pass along the relevant info, and updating the code emitters appropriately.

@ghost
Copy link

ghost commented Nov 11, 2022

Tagging subscribers to this area: @dotnet/area-system-text-regularexpressions
See info in area-owners.md if you want to be subscribed.

Issue Details

Once #78093 is merged, we'll want to use it in the RegexCompiler and source generator. This will require reworking the heuristics for when we consider sets viable for being used with IndexOf, updating the relevant data structures to pass along the relevant info, and updating the code emitters appropriately.

Author: stephentoub
Assignees: -
Labels:

area-System.Text.RegularExpressions

Milestone: 8.0.0

@MihaZupan MihaZupan self-assigned this Nov 12, 2022
@MihaZupan
Copy link
Member

I have some local experiments with this already. I'll take a crack at it and unassign myself if I fail miserably :)

@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Nov 28, 2022
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jan 5, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Feb 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants