-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
System.Diagnostics.Tests.PerformanceCounterTests failed in CI #60933
Comments
I'm reusing this issue since I've seen similar issue in different random tests across PerformanceCounters.
|
I'm unclear if Mono issue: #53261 is the same or not so leaving that one for now. The above are Windows only (happened on Win 10, Win 11, Win 7) all on amd64 (although unclear if it's specific to this arch) |
Also related: #60403 |
Noting from offline discussion -- for some reason, we are getting an incomplete read from the registry key (which I think is dynamically populated?). Recommendation is that if a category isn’t present, we should sleep for a little while, call CloseSharedResources(), and try again. We would do this in tests only -- unless something has changed in Windows, it doesn't seem to be affecting real-world use unless we hear otherwise. If it does affect customers, we could potentially do it inside CounterExists(..) but could not "fix" GetCategories() since we have no way to tell whether it's returning everything. |
Hit again in ci for net7.0-windows-Release-x86-CoreCLR_release-Windows.7.Amd64.Open: build, log.
|
These tests were disabled in dotnet#61101 due to random failures like dotnet#60933. We are continuing to see these failures on x86 as well.
More, where retries aren't enough and we should try this "CloseSharedResources()" ...
|
Hit again on #68921 . Build, and log:
|
Happened again in 1825417 (6/14 PM) - 10 test failures:
|
Frequency updated in previous post. Given it is not super-common lately, removing blocking-clean-ci label. |
Frequency:
Test System.Diagnostics.Tests.PerformanceCounterTests.PerformanceCounter_BeginInitEndInit_ProcessorCounter has failed. Check the Test tab or this console log: https://helix.dot.net/api/2019-06-17/jobs/7fb481c8-b204-4809-9ac6-1f7db90f5e5d/workitems/System.Diagnostics.PerformanceCounter.Tests/console
The text was updated successfully, but these errors were encountered: