Breaking change in release 7.2.2

[jkonecki]

I believe there is an unexpected breaking change introduced in release 7.2.2 through this PR:

#8596

Code that uses CollectionAgeLimitAttribute and sets one of the fields will fail to compile.

    [CollectionAgeLimit(Days = 30)]
    public class ConnectionSearchGrain { }

The above code will compile in Orleans 7.2.1, but in 7.2.2. will cause the following compile-time error:

Error CS0617 'Days' is not a valid named attribute argument. Named attribute arguments must be fields which are not readonly, static, or const, or read-write properties which are public and not static.

This is due to the change of property setters from set to init, which prohibits from using them in atribute declarations.

I suspect this in an unintented change, as it makes fields like AlwaysActive, Days, Hours, Minutes unusable.
I recommend changing properties from init back to set.

[jkonecki]

@ReubenBond would you like me to prepare a PR with the fix?

[ReubenBond]

You're right, this is unintended. I've got a PR ready: #8681

[jkonecki]

That's great!

On an unrelated note, while looking at the source code I've noticed the below:

        private TimeSpan CalculateValue()
        {
            var span = AlwaysActive
            ? TimeSpan.FromDays(short.MaxValue)
            : TimeSpan.FromDays(Days) + TimeSpan.FromHours(Hours) + TimeSpan.FromMinutes(Minutes);
            return span <= TimeSpan.Zero
                ? MinAgeLimit
                : span;
        }

Shouldn't the last line be:

            return span < MinAgeLimit
                ? MinAgeLimit
                : span;

I know that at the moment MinAgeLimit is set to one minute, but if it was changed in the future (or a Seconds property was introduced) than it will be possible to set the span that is shorter than MinAgeLimit

[ReubenBond]

Great catch, I've updated the PR

[jkonecki]

Awesome! Have a lovely weekend!

…

On Fri, 20 Oct 2023, 20:47 Reuben Bond, ***@***.***> wrote: Great catch, I've updated the PR — Reply to this email directly, view it on GitHub <#8680 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AANRND5TMWDHQR7OSIRN6XLYALIMDAVCNFSM6AAAAAA6JPKQ6WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZTGMYDSNZWGE> . You are receiving this because you authored the thread.Message ID: ***@***.***>