Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove BinaryFormatter #11323

Open
MichalPavlik opened this issue Jan 22, 2025 · 2 comments · May be fixed by #11346
Open

Remove BinaryFormatter #11323

MichalPavlik opened this issue Jan 22, 2025 · 2 comments · May be fixed by #11346
Assignees
@MichalPavlik
Labels
Priority:1 Work that is critical for the release, but we could probably ship without

Comments

@MichalPavlik
Copy link
Member

We can remove the last instance of the BinaryFormatter in our codebase. It will resolve CQL issue assigned to MSBuild.
@MichalPavlik MichalPavlik self-assigned this Jan 22, 2025
@MichalPavlik MichalPavlik added the Priority:1 Work that is critical for the release, but we could probably ship without label Jan 22, 2025
@YuliiaKovalova
Copy link
Member

could you please attach the problematic code paths?

@MichalPavlik
Copy link
Member Author

MichalPavlik commented Jan 27, 2025 •
edited
Loading

Sure:

msbuild/src/Framework/BinaryTranslator.cs

Line 508 in fcc0420

BinaryFormatter formatter = new BinaryFormatter();

msbuild/src/Framework/BinaryTranslator.cs

Line 1209 in fcc0420

BinaryFormatter formatter = new BinaryFormatter();

Invoked by WriteToStream and ReadFromStream in LogMessagePacketBase.

@MichalPavlik MichalPavlik linked a pull request Jan 28, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MichalPavlik MichalPavlik

Labels
Priority:1 Work that is critical for the release, but we could probably ship without
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removing last instances of the BinaryFormatter dotnet/msbuild
2 participants
@MichalPavlik @YuliiaKovalova