From 83db21200405878a9a68a01ade9feebf49efc6e4 Mon Sep 17 00:00:00 2001 From: Manodasan Wignarajah Date: Mon, 11 Nov 2024 16:06:11 -0800 Subject: [PATCH 1/3] Update Windows SDK projection for testing --- Directory.Build.props | 2 +- .../GraphicsTester.WinUI.Desktop.csproj | 2 +- src/Graphics/src/Graphics/Graphics.csproj | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Directory.Build.props b/Directory.Build.props index 409a1aeeef8a..f29ea918632b 100644 --- a/Directory.Build.props +++ b/Directory.Build.props @@ -129,7 +129,7 @@ - 10.0.19041.44 + 10.0.19041.56 diff --git a/src/Graphics/samples/GraphicsTester.WinUI.Desktop/GraphicsTester.WinUI.Desktop.csproj b/src/Graphics/samples/GraphicsTester.WinUI.Desktop/GraphicsTester.WinUI.Desktop.csproj index 4c6723a005ef..1a8cdbea6ed7 100644 --- a/src/Graphics/samples/GraphicsTester.WinUI.Desktop/GraphicsTester.WinUI.Desktop.csproj +++ b/src/Graphics/samples/GraphicsTester.WinUI.Desktop/GraphicsTester.WinUI.Desktop.csproj @@ -20,7 +20,7 @@ - 10.0.19041.44 + 10.0.19041.56 diff --git a/src/Graphics/src/Graphics/Graphics.csproj b/src/Graphics/src/Graphics/Graphics.csproj index 0debd85b06fa..2e6e343560c6 100644 --- a/src/Graphics/src/Graphics/Graphics.csproj +++ b/src/Graphics/src/Graphics/Graphics.csproj @@ -40,7 +40,7 @@ - 10.0.19041.45 + 10.0.19041.57 From 163bdc866bb13c89cfe3a7f3bd8e86cfaaa81f5b Mon Sep 17 00:00:00 2001 From: Manodasan Wignarajah Date: Tue, 12 Nov 2024 18:55:18 -0800 Subject: [PATCH 2/3] Attempt to fix build break from ordering issue --- Directory.Build.props | 24 ------------------------ Directory.Build.targets | 26 ++++++++++++++++++++++++++ 2 files changed, 26 insertions(+), 24 deletions(-) diff --git a/Directory.Build.props b/Directory.Build.props index f29ea918632b..b2919e9e721b 100644 --- a/Directory.Build.props +++ b/Directory.Build.props @@ -55,24 +55,6 @@ <_MauiPreviousDotNetVersion Condition="'$(_MauiPreviousDotNetVersion)' == ''">$(_MauiPreviousDotNetVersionMajor).$(_MauiPreviousDotNetVersionMinor) <_MauiPreviousDotNetVersionNoDot Condition="'$(_MauiPreviousDotNetVersionNoDot)' == ''">$(_MauiPreviousDotNetVersionMajor)$(_MauiPreviousDotNetVersionMinor) <_MauiPreviousDotNetTfm Condition="'$(_MauiPreviousDotNetTfm)' == ''">net$(_MauiPreviousDotNetVersion) - - <_MauiTargetPlatformIdentifier>$([MSBuild]::GetTargetPlatformIdentifier('$(TargetFramework)')) - <_MauiNoTargetPlatform>false - <_MauiNoTargetPlatform Condition="'$(_MauiTargetPlatformIdentifier)' == ''">True - <_MauiTargetPlatformIsAndroid>false - <_MauiTargetPlatformIsAndroid Condition="'$(_MauiTargetPlatformIdentifier)' == 'android'">True - <_MauiTargetPlatformIsiOS>false - <_MauiTargetPlatformIsiOS Condition="'$(_MauiTargetPlatformIdentifier)' == 'ios'">True - <_MauiTargetPlatformIsMacCatalyst>false - <_MauiTargetPlatformIsMacCatalyst Condition="'$(_MauiTargetPlatformIdentifier)' == 'maccatalyst'">True - <_MauiTargetPlatformIsmacOS>false - <_MauiTargetPlatformIsmacOS Condition="'$(_MauiTargetPlatformIdentifier)' == 'macos'">True - <_MauiTargetPlatformIstvOS>false - <_MauiTargetPlatformIstvOS Condition="'$(_MauiTargetPlatformIdentifier)' == 'tvos'">True - <_MauiTargetPlatformIsWindows>false - <_MauiTargetPlatformIsWindows Condition="$(_MauiTargetPlatformIdentifier.Contains('windows')) == 'True'">True - <_MauiTargetPlatformIsTizen>false - <_MauiTargetPlatformIsTizen Condition="'$(_MauiTargetPlatformIdentifier)' == 'tizen'">True @@ -116,7 +98,6 @@ - $(DefineConstants);WINDOWS $(DefineConstants);COMPATIBILITY_ENABLED $(DefineConstants);ENABLE_PREVIOUS_TFM_BUILDS @@ -127,11 +108,6 @@ true - - - 10.0.19041.56 - - diff --git a/Directory.Build.targets b/Directory.Build.targets index cdfa0ed38f55..da85b819e71a 100644 --- a/Directory.Build.targets +++ b/Directory.Build.targets @@ -29,6 +29,32 @@ $(NoWarn);MSB4011;NETSDK1206 + + <_MauiTargetPlatformIdentifier>$([MSBuild]::GetTargetPlatformIdentifier('$(TargetFramework)')) + <_MauiNoTargetPlatform>false + <_MauiNoTargetPlatform Condition="'$(_MauiTargetPlatformIdentifier)' == ''">True + <_MauiTargetPlatformIsAndroid>false + <_MauiTargetPlatformIsAndroid Condition="'$(_MauiTargetPlatformIdentifier)' == 'android'">True + <_MauiTargetPlatformIsiOS>false + <_MauiTargetPlatformIsiOS Condition="'$(_MauiTargetPlatformIdentifier)' == 'ios'">True + <_MauiTargetPlatformIsMacCatalyst>false + <_MauiTargetPlatformIsMacCatalyst Condition="'$(_MauiTargetPlatformIdentifier)' == 'maccatalyst'">True + <_MauiTargetPlatformIsmacOS>false + <_MauiTargetPlatformIsmacOS Condition="'$(_MauiTargetPlatformIdentifier)' == 'macos'">True + <_MauiTargetPlatformIstvOS>false + <_MauiTargetPlatformIstvOS Condition="'$(_MauiTargetPlatformIdentifier)' == 'tvos'">True + <_MauiTargetPlatformIsWindows>false + <_MauiTargetPlatformIsWindows Condition="$(_MauiTargetPlatformIdentifier.Contains('windows')) == 'True'">True + <_MauiTargetPlatformIsTizen>false + <_MauiTargetPlatformIsTizen Condition="'$(_MauiTargetPlatformIdentifier)' == 'tizen'">True + + + + + $(DefineConstants);WINDOWS + 10.0.19041.56 + + 13.0 From b87c40d58b311d2fb3c637d872d0eb527330aad5 Mon Sep 17 00:00:00 2001 From: Matthew Leibowitz Date: Thu, 14 Nov 2024 02:35:15 +0800 Subject: [PATCH 3/3] tests --- Directory.Build.props | 24 +++++++++++++++++ Directory.Build.targets | 26 ------------------- .../GraphicsTester.WinUI.Desktop.csproj | 4 --- src/Graphics/src/Graphics/Graphics.csproj | 4 --- 4 files changed, 24 insertions(+), 34 deletions(-) diff --git a/Directory.Build.props b/Directory.Build.props index b2919e9e721b..f29ea918632b 100644 --- a/Directory.Build.props +++ b/Directory.Build.props @@ -55,6 +55,24 @@ <_MauiPreviousDotNetVersion Condition="'$(_MauiPreviousDotNetVersion)' == ''">$(_MauiPreviousDotNetVersionMajor).$(_MauiPreviousDotNetVersionMinor) <_MauiPreviousDotNetVersionNoDot Condition="'$(_MauiPreviousDotNetVersionNoDot)' == ''">$(_MauiPreviousDotNetVersionMajor)$(_MauiPreviousDotNetVersionMinor) <_MauiPreviousDotNetTfm Condition="'$(_MauiPreviousDotNetTfm)' == ''">net$(_MauiPreviousDotNetVersion) + + <_MauiTargetPlatformIdentifier>$([MSBuild]::GetTargetPlatformIdentifier('$(TargetFramework)')) + <_MauiNoTargetPlatform>false + <_MauiNoTargetPlatform Condition="'$(_MauiTargetPlatformIdentifier)' == ''">True + <_MauiTargetPlatformIsAndroid>false + <_MauiTargetPlatformIsAndroid Condition="'$(_MauiTargetPlatformIdentifier)' == 'android'">True + <_MauiTargetPlatformIsiOS>false + <_MauiTargetPlatformIsiOS Condition="'$(_MauiTargetPlatformIdentifier)' == 'ios'">True + <_MauiTargetPlatformIsMacCatalyst>false + <_MauiTargetPlatformIsMacCatalyst Condition="'$(_MauiTargetPlatformIdentifier)' == 'maccatalyst'">True + <_MauiTargetPlatformIsmacOS>false + <_MauiTargetPlatformIsmacOS Condition="'$(_MauiTargetPlatformIdentifier)' == 'macos'">True + <_MauiTargetPlatformIstvOS>false + <_MauiTargetPlatformIstvOS Condition="'$(_MauiTargetPlatformIdentifier)' == 'tvos'">True + <_MauiTargetPlatformIsWindows>false + <_MauiTargetPlatformIsWindows Condition="$(_MauiTargetPlatformIdentifier.Contains('windows')) == 'True'">True + <_MauiTargetPlatformIsTizen>false + <_MauiTargetPlatformIsTizen Condition="'$(_MauiTargetPlatformIdentifier)' == 'tizen'">True @@ -98,6 +116,7 @@ + $(DefineConstants);WINDOWS $(DefineConstants);COMPATIBILITY_ENABLED $(DefineConstants);ENABLE_PREVIOUS_TFM_BUILDS @@ -108,6 +127,11 @@ true + + + 10.0.19041.56 + + diff --git a/Directory.Build.targets b/Directory.Build.targets index da85b819e71a..cdfa0ed38f55 100644 --- a/Directory.Build.targets +++ b/Directory.Build.targets @@ -29,32 +29,6 @@ $(NoWarn);MSB4011;NETSDK1206 - - <_MauiTargetPlatformIdentifier>$([MSBuild]::GetTargetPlatformIdentifier('$(TargetFramework)')) - <_MauiNoTargetPlatform>false - <_MauiNoTargetPlatform Condition="'$(_MauiTargetPlatformIdentifier)' == ''">True - <_MauiTargetPlatformIsAndroid>false - <_MauiTargetPlatformIsAndroid Condition="'$(_MauiTargetPlatformIdentifier)' == 'android'">True - <_MauiTargetPlatformIsiOS>false - <_MauiTargetPlatformIsiOS Condition="'$(_MauiTargetPlatformIdentifier)' == 'ios'">True - <_MauiTargetPlatformIsMacCatalyst>false - <_MauiTargetPlatformIsMacCatalyst Condition="'$(_MauiTargetPlatformIdentifier)' == 'maccatalyst'">True - <_MauiTargetPlatformIsmacOS>false - <_MauiTargetPlatformIsmacOS Condition="'$(_MauiTargetPlatformIdentifier)' == 'macos'">True - <_MauiTargetPlatformIstvOS>false - <_MauiTargetPlatformIstvOS Condition="'$(_MauiTargetPlatformIdentifier)' == 'tvos'">True - <_MauiTargetPlatformIsWindows>false - <_MauiTargetPlatformIsWindows Condition="$(_MauiTargetPlatformIdentifier.Contains('windows')) == 'True'">True - <_MauiTargetPlatformIsTizen>false - <_MauiTargetPlatformIsTizen Condition="'$(_MauiTargetPlatformIdentifier)' == 'tizen'">True - - - - - $(DefineConstants);WINDOWS - 10.0.19041.56 - - 13.0 diff --git a/src/Graphics/samples/GraphicsTester.WinUI.Desktop/GraphicsTester.WinUI.Desktop.csproj b/src/Graphics/samples/GraphicsTester.WinUI.Desktop/GraphicsTester.WinUI.Desktop.csproj index 1a8cdbea6ed7..6a992387a9c9 100644 --- a/src/Graphics/samples/GraphicsTester.WinUI.Desktop/GraphicsTester.WinUI.Desktop.csproj +++ b/src/Graphics/samples/GraphicsTester.WinUI.Desktop/GraphicsTester.WinUI.Desktop.csproj @@ -19,10 +19,6 @@ - - 10.0.19041.56 - - diff --git a/src/Graphics/src/Graphics/Graphics.csproj b/src/Graphics/src/Graphics/Graphics.csproj index 2e6e343560c6..f0f96248502c 100644 --- a/src/Graphics/src/Graphics/Graphics.csproj +++ b/src/Graphics/src/Graphics/Graphics.csproj @@ -39,10 +39,6 @@ - - 10.0.19041.57 - -