Fix android image loading race condition and improve logging #25870
+330
−49
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR aims to solve three issues:
Shell
Tab
s destroys theFragment
causing unwanted image unloading:Reloading images upon re-attach was handled in Check to see if Image Should Reload When Attached #24023 but we can provide a better UX here and avoid flashes while going back to the initial tab.
Glide is race-condition free, but we were setting the
Drawable
asynchronously in the next loop, this may generate glitches under some scrolling condition in collection viewGlide
integration:I've added proper logging mechanics which can be enabled via
adb
before running the application:Issues Fixed
#14587
#25783