Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HybridWebView: Clean up duplicate path manipulization/normalization code #23668

Open
Eilon opened this issue Jul 17, 2024 · 0 comments
Open

HybridWebView: Clean up duplicate path manipulization/normalization code #23668

Eilon opened this issue Jul 17, 2024 · 0 comments
Labels
area-controls-hybridwebview HybridWebView control s/triaged Issue has been reviewed t/bug Something isn't working

Comments

@Eilon
Copy link
Member

Eilon commented Jul 17, 2024

See PR comment: #22880 (comment)

@mattleibow said:

Can this rather use FileSystemPlatformOpenAppPackageFile instead of duplicating code?

@Eilon said:

The MAUI FileSystem APIs are unfortunately async-only (normally a good thing), but the Android API being implemented here is sync-only. For that reason I did the call directly because ultimately the low-level file system API on Android is sync anyway (just regular file system call). I have been unable to find a pattern to do async interception of Android WebView requests.

@mattleibow said:

Can we create an issue to track this, we already have FileSystemUtils.NormalizePath so we probably should create a helper for this and use it everywhere vs copying in all places.

@Eilon Eilon added the area-controls-hybridwebview HybridWebView control label Jul 17, 2024
@dotnet-policy-service dotnet-policy-service bot added the s/triaged Issue has been reviewed label Jul 17, 2024
@PureWeen PureWeen added this to the 9.0-preview7 milestone Jul 18, 2024
@samhouts samhouts added the t/bug Something isn't working label Jul 31, 2024
@PureWeen PureWeen modified the milestones: 9.0-preview7, 9.0-rc2 Aug 28, 2024
@Eilon Eilon modified the milestones: 9.0-rc2, .NET 10 Planning Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-controls-hybridwebview HybridWebView control s/triaged Issue has been reviewed t/bug Something isn't working
Projects
Status: Todo
Development

No branches or pull requests

3 participants