[Windows] Fix memory leak with GroupedItemTemplateCollection #23386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Foda
added
platform/windows 🪟
area-controls-collectionview
src/Controls/src/Core/Platform/Windows/CollectionView/GroupedItemTemplateCollection.cs
Outdated
Show resolved
Hide resolved
src/Controls/src/Core/Platform/Windows/CollectionView/GroupedItemTemplateCollection.cs
Show resolved
Hide resolved
|
/rebase |
github-actions
bot
force-pushed
the
foda/GroupItemListLeak
branch
from
8ec09aa
to
40daa0b
Compare
|
/rebase |
|
/azp |
Supported commands
See additional documentation. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
pictos
reviewed
Aug 23, 2024
| readonly WeakNotifyCollectionChangedProxy _proxy = new(); | ||
| bool _disposedValue; | ||
|
|
||
| ~GroupedItemTemplateCollection() => _proxy.Unsubscribe(); |
There was a problem hiding this comment.
On Dispose you do a null check with ? operator... Wouldn't make sense to do it here as well?
|
/rebase |
1 similar comment
|
/rebase |
MartyIX
reviewed
Oct 23, 2024
Comment on lines
+333
to
+335
| await Task.Yield(); | ||
| GC.Collect(); | ||
| GC.WaitForPendingFinalizers(); |
There was a problem hiding this comment.
There is a helper method that does it more robustly, is there not?
This one
, I believe.
|
/rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fix missing event cleanup in
GroupedItemTemplateCollectionto match the cleanup pattern inObservableItemTemplateCollection. This fixed a minor memory leak with grouped item collections on WindowsIssues Fixed
Fixes #22954